Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib/*: QNX 7.1 support #18936

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

klausholstjacobsen
Copy link
Contributor

@klausholstjacobsen klausholstjacobsen commented Jul 28, 2023

glib/2.76.1
glib/2.76.2
glib/2.76.3
glib/2.77.0

Added support for qnx 7.1 and onwards.


@conan-center-bot

This comment has been minimized.

@klausholstjacobsen klausholstjacobsen changed the title QNX 7.0 support for 2.76.1, 2.76.2, 2.76.3, 2.77.0 glib/*: QNX 7.0 support for 2.76.1, 2.76.2, 2.76.3, 2.77.0 Jul 30, 2023
@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Aug 21, 2023
@AbrilRBS
Copy link
Member

Thanks for your patience, just a heads-up that I've now beginning to look into this PR, thanks a lot as always :)

@valgur
Copy link
Contributor

valgur commented Aug 22, 2023

Since glib releases new versions fairly frequently, the amount of additional patches to maintain this PR adds is not ideal.

  1. Could these be and have you perhaps already shared these patches upstream as well?
  2. Could some of the less stable patches be replaced with a replace_in_file() or a save(..., append=True) call?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Aug 31, 2023
3 tasks
@conan-center-bot

This comment has been minimized.

@jcar87 jcar87 self-assigned this Sep 4, 2023
@jcar87
Copy link
Contributor

jcar87 commented Sep 4, 2023

Hi @klausholstjacobsen - thank you for your contribution. While we're happy to support platforms beyonds the one covered by our CI service, this PR introduces patches to C/C++ code that goes beyond we can validate. We don't know to what extent this was tested or validated, and we would not offer this to our users without minimal due diligence.

I would strongly suggest that the changes needed to support QNX 7.0 are proposed upstream to the glib maintainers, rather than the Conan Center recipe. If these patches already exist in an upstream version, please mention this in the PR description for traceability, along with a justification for backporting them to all other older versions.

Otherwise, I'm afraid this is not something we would be inclined to consider for merge.

@klausholstjacobsen
Copy link
Contributor Author

klausholstjacobsen commented Sep 4, 2023

@jcar87 You are absolutely correct. I was just sitting this morning contemplating this.
I have thus chosen to remove all patches related to qnx 7.0 as I cannot verify the origin
The good news is that the patched code is already built into qnx 7.1, so glib will build for qnx 7.1 with only a few remaining modifications to the recipe!

@klausholstjacobsen klausholstjacobsen force-pushed the glib branch 2 times, most recently from 39f9a05 to 0db41f1 Compare September 4, 2023 08:23
@ghost ghost mentioned this pull request Oct 11, 2023
3 tasks
@ghost ghost mentioned this pull request Oct 30, 2023
3 tasks
@ghost ghost mentioned this pull request Dec 23, 2023
3 tasks
@ghost ghost mentioned this pull request Mar 21, 2024
3 tasks
@ghost ghost mentioned this pull request Apr 15, 2024
@ghost ghost mentioned this pull request May 14, 2024
3 tasks
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 19, 2024
@conan-center-bot

This comment has been minimized.

@danimtb danimtb assigned danimtb and unassigned jcar87 and AbrilRBS Jul 26, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (a3554a75edb2e6dddf2069e7f7b5cdcbfe8cdc25):

  • glib/2.76.3:
    All packages built successfully! (All logs)

  • glib/2.81.0:
    All packages built successfully! (All logs)

  • glib/2.78.3:
    All packages built successfully! (All logs)

  • glib/2.77.3:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (a3554a75edb2e6dddf2069e7f7b5cdcbfe8cdc25):

  • glib/2.78.3:
    All packages built successfully! (All logs)

  • glib/2.81.0:
    All packages built successfully! (All logs)

  • glib/2.77.3:
    All packages built successfully! (All logs)

  • glib/2.76.3:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 8c7ec6b into conan-io:master Jul 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants