-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glib/*: QNX 7.1 support #18936
glib/*: QNX 7.1 support #18936
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks for your patience, just a heads-up that I've now beginning to look into this PR, thanks a lot as always :) |
Since glib releases new versions fairly frequently, the amount of additional patches to maintain this PR adds is not ideal.
|
7b0ce98
to
f725612
Compare
This comment has been minimized.
This comment has been minimized.
f725612
to
e3ef6d4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
10ada0c
to
beedbd8
Compare
This comment has been minimized.
This comment has been minimized.
Hi @klausholstjacobsen - thank you for your contribution. While we're happy to support platforms beyonds the one covered by our CI service, this PR introduces patches to C/C++ code that goes beyond we can validate. We don't know to what extent this was tested or validated, and we would not offer this to our users without minimal due diligence. I would strongly suggest that the changes needed to support QNX 7.0 are proposed upstream to the glib maintainers, rather than the Conan Center recipe. If these patches already exist in an upstream version, please mention this in the PR description for traceability, along with a justification for backporting them to all other older versions. Otherwise, I'm afraid this is not something we would be inclined to consider for merge. |
@jcar87 You are absolutely correct. I was just sitting this morning contemplating this. |
39f9a05
to
0db41f1
Compare
0f856ff
to
005e9a8
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
glib/2.76.1
glib/2.76.2
glib/2.76.3
glib/2.77.0
Added support for qnx 7.1 and onwards.