Add llvm libunwind callback to suppress exceptions on apple silicon #254
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 72.69% 72.70%
=======================================
Files 8 8
Lines 2963 2964 +1
=======================================
+ Hits 2154 2155 +1
Misses 809 809
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/Interpreter/Compatibility.h
Outdated
| #include "llvm/Support/Casting.h" | ||
| #include "llvm/Support/Path.h" | ||
|
|
||
| /home/maximus/cppyy-interop-dev/CppInterOp/llvm-project/compiler-rt/lib/orc/macho_platform.cpp |
There was a problem hiding this comment.
warning: expected unqualified-id [clang-diagnostic-error]
/home/maximus/cppyy-interop-dev/CppInterOp/llvm-project/compiler-rt/lib/orc/macho_platform.cpp
^
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
libunwind-fix
branch
2 times, most recently
from
a7ae7ef
to
be0085b
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@mcbarton, our cache sizes nowadays allow for having 1-2 osx-x86 builds. Are they easy to bring back? |
@vgvassilev Yes, they are easy to bring back. I'll put in a PR which brings them back. |
Nice! Thanks for the speed-of-light reply and PR! |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
libunwind-fix
branch
from
c3c8510
to
3a6db23
Compare
| dlsym(RTLD_DEFAULT, "__unw_remove_find_dynamic_unwind_sections")) | ||
| unw_remove_find_dynamic_unwind_sections(find_dynamic_unwind_sections); | ||
| #endif | ||
| sInterpreter.release(); |
There was a problem hiding this comment.
warning: the value returned by this function should be used [bugprone-unused-return-value]
sInterpreter.release();
^Additional context
lib/Interpreter/CppInterOp.cpp:109: cast the expression to void to silence this warning
sInterpreter.release();
^
Adding fix from
This adds the
find_dynamic_unwind_sectionscallback, used by libunwind to fix thelibc++abi: terminating due to uncaught exception of type inton apple silicon. This returns fake_mach_header as the header for all JIT'd code.The checks are performed during library loading and unloading time, and so have been added during interpreter creation and destruction called in
CppInterOp.cpp, via the leakedcompat::Interpreterclass