Update GetFunctionReturnType API for template functions #218
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| TEST(FunctionReflectionTest, GetFunctionReturnType) { | ||
| std::vector<Decl*> Decls, SubDecls; | ||
| std::vector<Decl*> Decls, SubDecls, TemplateSubDecls; |
There was a problem hiding this comment.
warning: variable 'Decls' is not initialized [cppcoreguidelines-init-variables]
| std::vector<Decl*> Decls, SubDecls, TemplateSubDecls; | |
| std::vector<Decl*> Decls = 0, SubDecls, TemplateSubDecls; |
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[5])), "Switch"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[4])), | ||
| "double"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[5])), |
There was a problem hiding this comment.
warning: 5 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[5])),
^| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[9])), "volatile N::C"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[10])), "const volatile N::C"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[11])), "NULL TYPE"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[7])), |
There was a problem hiding this comment.
warning: 7 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[7])),
^| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[11])), "NULL TYPE"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[7])), | ||
| "N::C *"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[8])), |
There was a problem hiding this comment.
warning: 8 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[8])),
^| "N::C *"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[8])), | ||
| "const N::C"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[9])), |
There was a problem hiding this comment.
warning: 9 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[9])),
^| "const N::C"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[9])), | ||
| "volatile N::C"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[10])), |
There was a problem hiding this comment.
warning: 10 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[10])),
^| "volatile N::C"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[10])), | ||
| "const volatile N::C"); | ||
| EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[11])), |
There was a problem hiding this comment.
warning: 11 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
EXPECT_EQ(Cpp::GetTypeAsString(Cpp::GetFunctionReturnType(Decls[11])),
^
| return FD->getReturnType().getAsOpaquePtr(); | ||
| } | ||
|
|
||
| if (auto* FD = llvm::dyn_cast_or_null<clang::FunctionTemplateDecl>(D)) { |
There was a problem hiding this comment.
Can D be null here? If not we need to drop the _or_null part.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 78.80% 78.82% +0.01%
==========================================
Files 8 8
Lines 3100 3102 +2
==========================================
+ Hits 2443 2445 +2
Misses 657 657
|
aaronj0
force-pushed
the
update-returntype-api
branch
from
ca6e56c to
173fea8
Compare
2 participants
No description provided.