fix dispatcher for rvalue #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires test, used in cross-inheritance
vgvassilev
reviewed
Nov 18, 2025
| CPPYY_IMPORT | ||
| std::string GetTypeAsString(TCppType_t type); | ||
| CPPYY_IMPORT | ||
| bool IsRValueReferenceType(TCppType_t type); |
There was a problem hiding this comment.
Isn't that better to be getValueKind and returning an enum?
Collaborator
Author
There was a problem hiding this comment.
I am just forwarding to CppInterOp's API here. Ref: https://github.com/compiler-research/CppInterOp/blob/main/lib/CppInterOp/CppInterOp.cpp#L1699-L1707
Also look at compiler-research/cppyy-backend#171
Collaborator
Author
There was a problem hiding this comment.
I have fixed CppInterOp's API to return an enum. Will merge that PR soon, once the CI is green.
For cppyy, I propose we keep the API like this. Otherwise, we will need to forward the enum from cppyy-backend to CPyCppyy. That may not be the best thing to do.
Vipul-Cariappa
merged commit 4d504ce
into
compiler-research:master
49 of 58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in cross-inheritance
Required for benchmarks.
TODO
Depends On
IsLValueReferenceType&IsRValueReferenceTypecppyy-backend#171