Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD fix knox dependency error on npm ci #1362

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

raulsperoni
Copy link

I was able to build client-report container with this change.

@patcon
Copy link
Contributor

patcon commented Nov 7, 2022

I think this PR might be where CI started breaking (at least for e2e tests)

Screen Shot 2022-11-07 at 7 15 58 PM

The past CI logs are now flushed, but it seems the the most recent available failing logs are still pointing to an issue in client-report where the wrong lockfile version is present:
https://github.com/compdemocracy/polis/actions/runs/3110297108/jobs/5041341778#step:9:1002

This seems to fit the change that happened (migration from one lockfile format to another in the package-lock.json during an upgrade).

I don't think we can upgrade node or npm right now for other reasons to do with gulp, so I think the cautious thing to do would be to revert this. (I suspect the issue with client-report that @raulsperoni was experiencing was likely related to the incorrect version of node that was being used anyhow.)

Does this sound like an ok path @metasoarous @colinmegill ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants