-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add russian localization #1354
Add russian localization #1354
Conversation
Thanks for this contribution @sevazhidkov! |
It seems that the error failing the build isn't related to the PR. I was able to make it work locally through these fixes (alongside running
@colinmegill, let me know what should I do: a) add these changes to this PR b) add these changes to a separate PR or something else. |
Hey @sevazhidkov; Thanks for submitting this PR, and for pointing out the knox dependency issue! The knox issue has been solved now thanks to #1362. However, GitHub doesn't seem to run the CI tests on the theoretical PR merge, but rather based directly on the head branch, so I went ahead and created #1363 to merge this branch with those changes. Now it seems that we're getting a different set of CI tests failing, specifically the cypress integration tests. This is weird, since these same tests seemed to pass for @raulsperoni in #1362. |
Hey! I've launched the tests a few times, every time they failed in different places and, after multiple retries, they passed: https://github.com/sevazhidkov/polis/actions/runs/2086388973 Do you mind trying to retry the tests a few times? If they end up succeeding, it could unblock merging the localization PR before I figure out a reason for their flakiness. |
Hey @sevazhidkov; Thanks for your persistence with this. I've got some other work I need to do on the deploy side right now, but once I'm through with that, I'll do as you suggest to try and get this merged in. Thanks again! |
Merging this now; Thanks again @sevazhidkov! |
No description provided.