Skip to content

fix(water caustics): x4000 warnings #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davo0411 wants to merge 2 commits into
base: dev
Choose a base branch
from
+5 −3
Open

fix(water caustics): x4000 warnings #2502

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e80f50
Update WaterCaustics.hlsli
davo0411 Jun 12, 2026
0376aea
Update WaterCaustics.hlsli
davo0411 Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions features/Water Effects/Shaders/WaterEffects/WaterCaustics.hlsli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ namespace WaterEffects
float2 causticsUV2 = PanCausticsUV(causticsUV, 1.0 * 0.2, -0.5);

float3 causticsHigh = 1.0.xxx;
if (causticsFade > 0.0)
if (causticsFade > 0.0) {
causticsHigh = min(SampleCausticsDispersion(causticsUV1, dispersionOffset), SampleCausticsDispersion(causticsUV2, dispersionOffset)) * 4.0;
}

causticsUV *= 0.5;
dispersionOffset *= 0.5;
Expand All @@ -49,10 +50,11 @@ namespace WaterEffects
causticsUV2 = PanCausticsUV(causticsUV, 1.0 * 0.1, -0.5);

float3 causticsLow = 1.0.xxx;
if (causticsFade < 1.0)
if (causticsFade < 1.0) {
causticsLow = min(SampleCausticsDispersion(causticsUV1, dispersionOffset), SampleCausticsDispersion(causticsUV2, dispersionOffset)) * 4.0;
}

float3 caustics = lerp(causticsLow, causticsHigh, causticsFade);
const float3 caustics = lerp(causticsLow, causticsHigh, causticsFade);
return lerp(1.0.xxx, caustics, shoreFactorCaustics);
}

Expand Down
Loading