fix(water effects): fix water caustics X4000 warnings

[davo0411]

should address some warning X4000 (“use of potentially uninitialized variable”) warnings

Summary by CodeRabbit

• Refactor
  • Internal cleanup of the water caustics shader for improved maintainability; no visual changes to caustics rendering.
• Chores
  • Water effects configuration version bumped (minor patch update).

[coderabbitai]

📝 Walkthrough

Walkthrough

ComputeCaustics in WaterCaustics.hlsli was edited to compute causticsHigh and causticsLow as const ternary expressions based on causticsFade; interpolation and returned value are unchanged. The Features/WaterEffects.ini version was bumped from 1-1-1 to 1-1-2.

Changes

Water Caustics refactor

Layer / File(s)	Summary
Core computation features/Water Effects/Shaders/WaterEffects/WaterCaustics.hlsli	ComputeCaustics replaces mutable causticsHigh/causticsLow and single-statement if assignments with const ternary expressions dependent on causticsFade; sampling, lerp, and return path unchanged.
Metadata / Version features/Water Effects/Shaders/Features/WaterEffects.ini	Version in [Info] changed from 1-1-1 to 1-1-2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• doodlum
• alandtse

Poem

I'm a rabbit in the code tonight,
Ternaries neat, all tidy and bright,
No signature moved, no behavior gone,
Just cleaner hops from dusk to dawn,
Shaders shimmer, small delight. 🐇✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title 'fix(water effects): fix water caustics X4000 warnings' directly addresses the PR's main objective of eliminating compiler X4000 warnings in water caustics shader code.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[Copilot]

Pull request overview

This PR aims to eliminate HLSL compiler warning X4000 (“use of potentially uninitialized variable”) in the Water Caustics shader code used by the Water Effects feature.

Changes:

• Added braces around single-statement if blocks in ComputeCaustics().
• Made the final caustics intermediate value const.

[coderabbitai]

🧹 Nitpick comments (1)

features/Water Effects/Shaders/Features/WaterEffects.ini (1)

2-2: Consider linking the fix to a tracked issue (if one exists).

If this warning cleanup maps to an existing issue, add Fixes #<id> or Closes #<id> in the PR description for traceability.

As per coding guidelines, "Issue References (if PR fixes bugs or implements features): Suggest adding appropriate GitHub keywords."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@features/Water` Effects/Shaders/Features/WaterEffects.ini at line 2, This
PR's change in Features/Water Effects/Shaders/Features/WaterEffects.ini (Version
= 1-1-2) should be linked to a tracked issue for traceability; if this warning
cleanup resolves an existing issue, update the PR description to include the
appropriate GitHub keyword like "Fixes #<id>" or "Closes #<id>" referencing the
issue number so the change is automatically linked and closed.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@features/Water` Effects/Shaders/Features/WaterEffects.ini:
- Line 2: This PR's change in Features/Water
Effects/Shaders/Features/WaterEffects.ini (Version = 1-1-2) should be linked to
a tracked issue for traceability; if this warning cleanup resolves an existing
issue, update the PR description to include the appropriate GitHub keyword like
"Fixes #<id>" or "Closes #<id>" referencing the issue number so the change is
automatically linked and closed.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c91f3531-2be4-4f20-9838-fecf20ee6b56

📥 Commits

Reviewing files that changed from the base of the PR and between 66b0aa5 and a84bb2c.

📒 Files selected for processing (1)

• features/Water Effects/Shaders/Features/WaterEffects.ini

[coderabbitai]

🧹 Nitpick comments (1)

features/Water Effects/Shaders/WaterEffects/WaterCaustics.hlsli (1)

1-50: ⚡ Quick win

Consider updating the commit title to use fix type with a scope.

The current title build: fix water caustics X4000 warnings uses the build type, which per Conventional Commits is intended for build-system or tooling changes (e.g., CMake, compiler flags). Since the change is in shader source code, fix is the more accurate type. Adding a scope also improves traceability.

💬 Suggested title

- build: fix water caustics X4000 warnings
+ fix(water): resolve X4000 uninitialized variable warnings in caustics

As per coding guidelines: "Conventional Commit Titles — Format: type(scope): description".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@features/Water` Effects/Shaders/WaterEffects/WaterCaustics.hlsli around lines
1 - 50, The commit title should use the `fix` type with a scope instead of
`build`; update the commit message for the change in WaterCaustics.hlsli
(affecting symbols like ComputeCaustics, PanCausticsUV and the WaterCaustics
texture) to follow Conventional Commits, e.g. "fix(WaterEffects): fix water
caustics X4000 warnings" (or a similar scope that reflects the
shader/WaterEffects area) by amending the commit message via git commit --amend
or creating a new commit with the corrected title.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@features/Water` Effects/Shaders/WaterEffects/WaterCaustics.hlsli:
- Around line 1-50: The commit title should use the `fix` type with a scope
instead of `build`; update the commit message for the change in
WaterCaustics.hlsli (affecting symbols like ComputeCaustics, PanCausticsUV and
the WaterCaustics texture) to follow Conventional Commits, e.g.
"fix(WaterEffects): fix water caustics X4000 warnings" (or a similar scope that
reflects the shader/WaterEffects area) by amending the commit message via git
commit --amend or creating a new commit with the corrected title.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: de3047ef-fe65-49ce-a267-fa05868f2c00

📥 Commits

Reviewing files that changed from the base of the PR and between a84bb2c and 4f4e84d.

📒 Files selected for processing (1)

• features/Water Effects/Shaders/WaterEffects/WaterCaustics.hlsli