Skip to content

fix(weather-editor): weather widget sliders #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 2 commits into from
Apr 22, 2026
Merged

fix(weather-editor): weather widget sliders #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3e3173
fix: weather editor widget sliders
Apr 21, 2026
ab8f04e
fix: address AI comment
Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Features/WeatherEditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ void WeatherEditor::LerpWeather(RE::TESWeather* oldWeather, RE::TESWeather* newW
newWeather->data.precipitationEndFadeOut = LerpUint8_t(oldWeather->data.precipitationEndFadeOut, newWeather->data.precipitationEndFadeOut, currentWeatherPct);

//// Sun
newWeather->data.sunDamage = LerpInt8_t(oldWeather->data.sunDamage, newWeather->data.sunDamage, currentWeatherPct);
newWeather->data.sunGlare = LerpInt8_t(oldWeather->data.sunGlare, newWeather->data.sunGlare, currentWeatherPct);
newWeather->data.sunDamage = LerpUint8_t(oldWeather->data.sunDamage, newWeather->data.sunDamage, currentWeatherPct);
newWeather->data.sunGlare = LerpUint8_t(oldWeather->data.sunGlare, newWeather->data.sunGlare, currentWeatherPct);

//// Lightning
newWeather->data.thunderLightningBeginFadeIn = LerpUint8_t(oldWeather->data.thunderLightningBeginFadeIn, newWeather->data.thunderLightningBeginFadeIn, currentWeatherPct);
Expand Down
14 changes: 7 additions & 7 deletions src/WeatherEditor/Weather/WeatherWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ void WeatherWidget::DrawWidget()

if (ImGui::BeginTabItem("Basic", nullptr, basicFlags)) {
BeginScrollableContent("##BasicScroll");
DrawProperties("Sun", { { "Sun Damage", INT8_SLIDER } });
DrawProperties("Sun", { { "Sun Damage", UINT8_SLIDER } });
Comment thread
SkrubbySkrubInAShrub marked this conversation as resolved.
DrawProperties("Wind", { { "Wind Speed", UINT8_SLIDER }, { "Wind Direction", INT8_SLIDER }, { "Wind Direction Range", INT8_SLIDER } });
DrawProperties("Precipitation", { { "Precipitation Begin Fade In", UINT8_SLIDER }, { "Precipitation End Fade Out", UINT8_SLIDER } });
DrawProperties("Lightning", { { "Thunder Lightning Begin Fade In", UINT8_SLIDER }, { "Thunder Lightning End Fade Out", UINT8_SLIDER },
Expand Down Expand Up @@ -561,8 +561,8 @@ void WeatherWidget::SetWeatherValues()
weather->data.transDelta = (uint8_t)weatherProps["Trans Delta"];

// Sun
data.sunGlare = (int8_t)weatherProps["Sun Glare"];
data.sunDamage = (int8_t)weatherProps["Sun Damage"];
data.sunGlare = (uint8_t)weatherProps["Sun Glare"];
data.sunDamage = (uint8_t)weatherProps["Sun Damage"];

// Precipitation
data.precipitationBeginFadeIn = (uint8_t)weatherProps["Precipitation Begin Fade In"];
Expand Down Expand Up @@ -1240,11 +1240,11 @@ void WeatherWidget::DrawFogSettings()
ImGui::Text("Near");
ImGui::TableSetColumnIndex(1);
ImGui::SetNextItemWidth(-1);
if (ImGui::SliderFloat("##FogDayNear", &settings.fogProperties["Day Near"], 0.0f, 1000000.0f, "%.0f"))
if (ImGui::SliderFloat("##FogDayNear", &settings.fogProperties["Day Near"], 0.0f, 350000.0f, "%.0f"))
changed = true;
ImGui::TableSetColumnIndex(2);
ImGui::SetNextItemWidth(-1);
if (ImGui::SliderFloat("##FogNightNear", &settings.fogProperties["Night Near"], 0.0f, 1000000.0f, "%.0f"))
if (ImGui::SliderFloat("##FogNightNear", &settings.fogProperties["Night Near"], 0.0f, 350000.0f, "%.0f"))
changed = true;

// Far
Expand All @@ -1268,11 +1268,11 @@ void WeatherWidget::DrawFogSettings()
ImGui::Text("Far");
ImGui::TableSetColumnIndex(1);
ImGui::SetNextItemWidth(-1);
if (ImGui::SliderFloat("##FogDayFar", &settings.fogProperties["Day Far"], 0.0f, 1000000.0f, "%.0f"))
if (ImGui::SliderFloat("##FogDayFar", &settings.fogProperties["Day Far"], 0.0f, 350000.0f, "%.0f"))
changed = true;
ImGui::TableSetColumnIndex(2);
ImGui::SetNextItemWidth(-1);
if (ImGui::SliderFloat("##FogNightFar", &settings.fogProperties["Night Far"], 0.0f, 1000000.0f, "%.0f"))
if (ImGui::SliderFloat("##FogNightFar", &settings.fogProperties["Night Far"], 0.0f, 350000.0f, "%.0f"))
changed = true;

// Power
Expand Down
Loading