Skip to content

fix(reflex): add old reflex dll to incompatible list#2170

Merged
alandtse merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:Block-old-Reflex
Apr 22, 2026
Merged

fix(reflex): add old reflex dll to incompatible list#2170
alandtse merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:Block-old-Reflex

Conversation

@SkrubbySkrubInAShrub
Copy link
Copy Markdown
Collaborator

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub commented Apr 21, 2026

fixes: #2167

Summary by CodeRabbit

  • Bug Fixes
    • Added detection for NVIDIA_Reflex plugin incompatibility. Users will now receive notification if this incompatible component is detected during plugin initialization.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

📝 Walkthrough

Walkthrough

Added NVIDIA_Reflex.dll to the incompatible DLLs list in the plugin loader. When this DLL is detected, the plugin will log an incompatibility error and prevent its loading alongside other features.

Changes

Cohort / File(s) Summary
Incompatible DLL Configuration
src/XSEPlugin.cpp
Added Data/SKSE/Plugins/NVIDIA_Reflex.dll entry to the incompatibleDLLs list to prevent loading and report incompatibility detection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • jiayev

Poem

🐰 A reflex so swift, yet it lags and it drags,
Into the blocklist it goes without snags!
No more laggy frames, just smooth sailing scenes,
Our plugin now guards against performance thieves. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR successfully implements the requirement from issue #2167 by adding NVIDIA_Reflex.dll to the incompatible DLLs list to prevent lag.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the linked issue requirement; only the incompatibleDLLs list was modified with the NVIDIA_Reflex.dll entry.
Title check ✅ Passed The title clearly and concisely describes the main change: adding an old Reflex DLL to the incompatible list, which matches the actual code modification.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@doodlum doodlum changed the title fix(Reflex): add old reflex mod dll to incompatible list. fix(reflex): add old reflex mod dll to incompatible list. Apr 21, 2026
@alandtse alandtse changed the title fix(reflex): add old reflex mod dll to incompatible list. fix(reflex): add old reflex dll to incompatible list Apr 22, 2026
@alandtse alandtse merged commit df80ff2 into community-shaders:dev Apr 22, 2026
8 checks passed
IgorAlanAlbuquerque pushed a commit to IgorAlanAlbuquerque/skyrim-community-shaders that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doodles reflex dll causes lag; block it

3 participants