chore: add more incompatible DLLs

[doodlum]

Summary by CodeRabbit

• Bug Fixes
  • Improved conflict detection by recognizing additional incompatible plugins (e.g., EVLaS, AELAS, SSE ReShade Helper, Skyrim Upscaler). If detected at startup, the app now shows a clear error message and disables conflicting features, reducing crashes and unexpected behavior. This helps you quickly identify problematic setups and ensures more stable, predictable launches.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The incompatible DLLs array in src/XSEPlugin.cpp’s Load() was expanded to include EVLaS.dll, AELAS.dll, and SSEReShadeHelper.dll alongside SkyrimUpscaler.dll. The existing logic—detect loaded incompatible DLLs, log an error, and record it in errors—remains unchanged. No public/exported declarations were modified.

Changes

Cohort / File(s)	Summary
Plugin compatibility checks src/XSEPlugin.cpp	Extended the incompatible DLLs list in Load() to include EVLaS.dll, AELAS.dll, and SSEReShadeHelper.dll; preserved existing detection, logging, and error aggregation behavior.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Game as Game Runtime
  participant Plugin as XSEPlugin::Load()
  participant OS as OS Loader

  Game->>Plugin: Initialize plugin (Load)
  Plugin->>OS: Query loaded modules
  OS-->>Plugin: Module list
  alt Incompatible DLL present (e.g., EVLaS.dll, AELAS.dll, SSEReShadeHelper.dll, SkyrimUpscaler.dll)
    Plugin->>Plugin: Log error and append to errors
  else No incompatible DLLs found
    Plugin->>Plugin: Continue normal validation/load
  end
  Plugin-->>Game: Return (with errors if any)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix: fix engine fixes requirement on vr #1461 — Also modifies DLL handling in Load(), updating incompatible list and VR-specific EngineFixes DLL selection.
• chore: configure CS to require engine fixes #1452 — Adjusts Load() DLL-check logic, including arrays for incompatible/required DLLs and their iteration.

Suggested reviewers

• jiayev

Poem

I hop through code with whiskers keen,
Sniffing DLLs, both heard and seen—
EVLaS? AELAS? Not today!
I thump a log, then bound away.
With tidy lists and errors neat,
This burrow’s build stays clean and sweet. 🐇✨

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch incompatible-dlls

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd67247 and fbe4d61.

📒 Files selected for processing (1)

• src/XSEPlugin.cpp (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Using provided base ref: cd67247
Using base ref: cd67247
Base commit date: 2025-09-16T01:09:21+01:00 (Tuesday, September 16, 2025 01:09 AM)
No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download