Skip to content

fix(weather-editor): loss of focus on searchbar when typing #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davo0411 merged 1 commit into from
Apr 17, 2026
+8 −6
Merged

fix(weather-editor): loss of focus on searchbar when typing #2145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/WeatherEditor/Weather/WeatherWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#include <format>

#include "imgui_internal.h"

Copy link
Copy Markdown
Collaborator

@davo0411 davo0411 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary or ai silly

#include "../EditorWindow.h"
#include "FeatureIssues.h"
#include "State.h"
Expand Down Expand Up @@ -59,6 +61,7 @@ void WeatherWidget::DrawWidget()
if (BeginWidgetWindow()) {
// Draw header with search and all buttons
DrawWidgetHeader("##WeatherSearch", false, true, true, weather);
const ImVec2 searchDropdownPos = ImGui::GetCursorScreenPos();

// Update search results when search buffer changes
if (searchActive) {
Expand All @@ -67,15 +70,15 @@ void WeatherWidget::DrawWidget()

// Show search results dropdown
if (searchBuffer[0] != '\0' && !searchResults.empty()) {
// Find the search input position for dropdown placement
ImGui::SetNextWindowPos(ImVec2(ImGui::GetCursorScreenPos().x, ImGui::GetCursorScreenPos().y));
ImGui::SetNextWindowPos(searchDropdownPos, ImGuiCond_Always);
ImGui::SetNextWindowSize(ImVec2(300.0f * Util::GetUIScale(), 0));
ImGui::SetNextWindowFocus();
ImGui::PushStyleVar(ImGuiStyleVar_Alpha, 1.0f);
ImGui::PushStyleColor(ImGuiCol_WindowBg, ImVec4(0.16f, 0.16f, 0.16f, 1.0f));
if (ImGui::Begin("##SearchDropdown", nullptr,
ImGuiWindowFlags_NoTitleBar | ImGuiWindowFlags_NoMove | ImGuiWindowFlags_NoResize |
ImGuiWindowFlags_NoScrollbar | ImGuiWindowFlags_AlwaysAutoResize | ImGuiWindowFlags_NoSavedSettings)) {
ImGuiWindowFlags_NoScrollbar | ImGuiWindowFlags_AlwaysAutoResize | ImGuiWindowFlags_NoSavedSettings |
ImGuiWindowFlags_NoFocusOnAppearing)) {
ImGui::BringWindowToDisplayFront(ImGui::GetCurrentWindow());
for (size_t i = 0; i < std::min(size_t(5), searchResults.size()); ++i) {
const auto& result = searchResults[i];
std::string label = std::format("{} ({})", result.displayName, result.tabName);
Expand All @@ -92,8 +95,7 @@ void WeatherWidget::DrawWidget()
ImGui::TextDisabled("... %zu more results", searchResults.size() - 5);
}

// Close dropdown if clicking outside or pressing Escape
if (!ImGui::IsWindowFocused() || ImGui::IsKeyPressed(ImGuiKey_Escape)) {
if (ImGui::IsKeyPressed(ImGuiKey_Escape)) {
searchBuffer[0] = '\0';
searchResults.clear();
}
Expand Down
Loading