fix(weather-editor): loss of focus on searchbar when typing

[SkrubbySkrubInAShrub]

Fixes bug where you would lose focus on the searchbar after entering 1 character, preventing the input of the next.

Summary by CodeRabbit

• Bug Fixes
  • Improved search dropdown positioning and placement stability in the weather editor.
  • Refined search dropdown dismissal behavior to prevent unintended closing when clicking nearby areas.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cad85a04-8fca-48b1-bf24-0465c8492587

📥 Commits

Reviewing files that changed from the base of the PR and between a847bd9 and c0b98bf.

📒 Files selected for processing (1)

• src/WeatherEditor/Weather/WeatherWidget.cpp

---

📝 Walkthrough

Walkthrough

Modified the search dropdown positioning and focus behavior in WeatherWidget. Replaced repeated cursor position calls with a single captured position, adjusted ImGui window flags to prevent automatic focus, and simplified dropdown dismissal to use only Escape key, removing focus-based closure logic.

Changes

Cohort / File(s)	Summary
Search Dropdown Positioning & Focus src/WeatherEditor/Weather/WeatherWidget.cpp	Refactored dropdown positioning to capture cursor position once instead of repeatedly; replaced focus behavior with ImGuiWindowFlags_NoFocusOnAppearing flag; added window-to-front call; simplified dismissal logic to use only Escape key instead of focus state.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(weather-editor): corrected slider behaviour for the weather widget #2132: Modifies WeatherWidget::DrawWidget dropdown positioning and focus behavior alongside slider adjustments.
• feat(weather editor): sticky headers and scrollable content #1930: Adjusts search dropdown positioning and focus in WeatherWidget::DrawWidget alongside layout changes.
• fix(UI): DPI-aware window layouts #2000: Modifies WeatherWidget::DrawWidget in the same file with related UI widget adjustments.

Suggested reviewers

• davo0411
• alandtse

Poem

🐰 A dropdown finds its perfect place,
No wandering cursors, a focused grace,
With Escape alone to bid farewell,
The search behaves more smooth and well! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main issue being fixed: preventing loss of focus on the searchbar when typing.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[davo0411]

is this necessary or ai silly

[github-actions]

✅ A pre-release build is available for this PR:
Download