fix(ibl): disable interior IBL by default

[Dlizzio]

Changes IBL toggle to function as disabled by default, serializes it.

Summary by CodeRabbit

• New Features

  • Added "Enable Interior IBL" setting to control Image-Based Lighting behavior in interior spaces.

• Changes

  • Removed the previous "Disable in interiors" setting; users should now utilize the new "Enable Interior IBL" option instead.
  • Updated Image-Based Lighting interior environment handling for improved consistency.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 50708a94-0476-4495-9dfb-ba2f1fe24a6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This PR refactors the IBL feature's settings structure by introducing a new PerFrame struct containing shared buffer fields, making Settings inherit from it with an added EnableInteriorIBL boolean. The separate disableInInteriors setting is removed, and interior gating logic is updated to use the new inverted flag. The GetCommonBufferData() method's return type changes from Settings to PerFrame.

Changes

Cohort / File(s)	Summary
IBL Header Structure src/Features/IBL.h	Introduced PerFrame struct with common buffer fields; Settings now inherits from PerFrame and adds EnableInteriorIBL boolean; removed disableInInteriors member; updated GetCommonBufferData() return type to PerFrame.
IBL Implementation Logic src/Features/IBL.cpp	Updated GetCommonBufferData() to return PerFrame and apply interior gating via EnableInteriorIBL flag; modified ReflectionsPrepass() shader-resource selection to use inverted interior condition; updated Prepass() early-return logic; replaced "Disable in interiors" UI checkbox with "Enable Interior IBL" and removed related serialization code.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(extended translucency): apply extra data and implicit alpha #1365: Introduces the same PerFrame struct pattern with Settings inheritance and changes GetCommonBufferData return type to PerFrame.
• feat(IBL): disable-interior-only toggle button #2020: Addresses the inverse logic for interior IBL toggling—previous PR added disableInInteriors, this PR replaces it with EnableInteriorIBL.
• chore(Linear Lighting): separate directional light multiplier sliders #1730: Refactors feature settings into per-frame data structures with interior-vs-exterior conditional behavior using similar GetCommonBufferData patterns.

Suggested reviewers

• jiayev
• doodlum
• alandtse

Poem

🐰 IBL's interior dreams now crystal clear,
Settings dance with PerFrame, structurally cheer,
EnableInteriorIBL shines bright and true,
Refactored, redesigned, our feature made new! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: converting interior IBL control from a separate 'disableInInteriors' setting to an 'EnableInteriorIBL' toggle disabled by default with serialization support.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download