Skip to content

chore(Linear Lighting): separate directional light multiplier sliders#1730

Merged
doodlum merged 1 commit into
community-shaders:devfrom
Dlizzio:chore(LL)-separate-interior-vs-exterior-directional-light-multiplier
Jan 17, 2026
Merged

chore(Linear Lighting): separate directional light multiplier sliders#1730
doodlum merged 1 commit into
community-shaders:devfrom
Dlizzio:chore(LL)-separate-interior-vs-exterior-directional-light-multiplier

Conversation

@Dlizzio
Copy link
Copy Markdown
Contributor

@Dlizzio Dlizzio commented Jan 17, 2026

Separated directional light multiplier for interiors vs exteriors.

For compatibility with interior sun.

Summary by CodeRabbit

  • New Features
    • Directional light multiplier now split into separate Exterior and Interior controls with individual adjustment sliders.
    • The app automatically applies the appropriate lighting multiplier based on your current location.

✏️ Tip: You can customize this high-level summary in your review settings.

…ht multipliers

For compatibility with interior sun.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

The directional light multiplier in LinearLighting is split into two context-aware variants: one for exterior environments and one for interior environments. The runtime logic now selects the appropriate multiplier based on the player's current location.

Changes

Cohort / File(s) Summary
LinearLighting Header & Implementation
src/Features/LinearLighting.h, src/Features/LinearLighting.cpp
Replaced single directionalLightMult setting field with directionalLightMultExterior and directionalLightMultInterior. Updated GetCommonBufferData() to conditionally select the appropriate multiplier via Util::IsInterior(). PerFrameData field marked as computed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • jiayev
  • doodlum

Poem

🐰 Two lights now shine where once was one,
Exterior glow and interior sun,
The rabbit hops between the lands,
Each setting multiplied by clever hands!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: splitting a single directional light multiplier field into separate exterior and interior variants with corresponding UI sliders.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Using provided base ref: fde3f5a
Using base ref: fde3f5a
Base commit date: 2026-01-17T15:30:44Z (Saturday, January 17, 2026 03:30 PM)
No actionable suggestions for changed features.

@github-actions
Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

@doodlum doodlum merged commit 20b477b into community-shaders:dev Jan 17, 2026
16 checks passed
@Dlizzio Dlizzio deleted the chore(LL)-separate-interior-vs-exterior-directional-light-multiplier branch March 27, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants