Skip to content

refactor(UI): move light limit visualization into debug #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alandtse merged 2 commits into from
Dec 3, 2025
Merged

refactor(UI): move light limit visualization into debug #1619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c23e973
feat(UI): move light limit visualization into debug section
brucenguyen Dec 2, 2025
3733fb8
fix: make light visualisation ephemeral
brucenguyen Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/Features/LightLimitFix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,22 @@ static constexpr uint MAX_LIGHTS = 1024;
NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE_WITH_DEFAULT(
LightLimitFix::Settings,
EnableContactShadows,
EnableLightsVisualisation,
LightsVisualisationMode)

void LightLimitFix::DrawSettings()
{
auto shaderCache = globals::shaderCache;

if (ImGui::TreeNodeEx("Light Limit Visualization", ImGuiTreeNodeFlags_DefaultOpen)) {
if (ImGui::TreeNodeEx("Statistics", ImGuiTreeNodeFlags_DefaultOpen)) {
ImGui::Text(std::format("Clustered Light Count : {}", lightCount).c_str());

ImGui::TreePop();
}

///////////////////////////////
ImGui::SeparatorText("Debug");

if (ImGui::TreeNode("Light Limit Visualization")) {
ImGui::Checkbox("Enable Lights Visualisation", &settings.EnableLightsVisualisation);
if (auto _tt = Util::HoverTooltipWrapper()) {
ImGui::Text("Enables visualization of the light limit\n");
Expand All @@ -43,12 +51,6 @@ void LightLimitFix::DrawSettings()

ImGui::TreePop();
}

if (ImGui::TreeNodeEx("Statistics", ImGuiTreeNodeFlags_DefaultOpen)) {
ImGui::Text(std::format("Clustered Light Count : {}", lightCount).c_str());

ImGui::TreePop();
}
}

LightLimitFix::PerFrame LightLimitFix::GetCommonBufferData()
Expand Down Expand Up @@ -563,4 +565,4 @@ void LightLimitFix::Hooks::BSWaterShader_SetupGeometry::thunk(RE::BSShader* This
auto& singleton = globals::features::lightLimitFix;
singleton.BSLightingShader_SetupGeometry_Before(Pass);
singleton.BSLightingShader_SetupGeometry_After(Pass);
};
};