Skip to content

fix(upscaling): fix mipbias sometimes being wrong #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doodlum merged 2 commits into from
Sep 24, 2025
+4 −4
Merged

fix(upscaling): fix mipbias sometimes being wrong #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5119eaf
fix(upscaling): lazy mipbias fix
doodlum Sep 24, 2025
682c8db
chore: lower fsr sharpness idc
doodlum Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Features/Upscaling/FidelityFX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ void FidelityFX::Upscale(ID3D11Resource* a_upscalingTexture, ID3D11Resource* a_r
dispatchParameters.cameraNear = *globals::game::cameraNear;

dispatchParameters.enableSharpening = true;
dispatchParameters.sharpness = 0.5f;
dispatchParameters.sharpness = 0.0f;

dispatchParameters.cameraFovAngleVertical = Util::GetVerticalFOVRad();
dispatchParameters.viewSpaceToMetersFactor = 0.01428222656f;
Expand Down
6 changes: 3 additions & 3 deletions src/State.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ void State::SetAdapterDescription(const std::wstring& description)
adapterDescription = converter.to_bytes(description);
}

void State::UpdateSharedData(bool a_inWorld, bool a_prepass)
void State::UpdateSharedData([[maybe_unused]] bool a_inWorld, [[maybe_unused]] bool a_prepass)
{
{
SharedDataCB data{};
Expand Down Expand Up @@ -764,8 +764,8 @@ void State::UpdateSharedData(bool a_inWorld, bool a_prepass)

if (upscaling.loaded) {
auto upscaleMethod = upscaling.GetUpscaleMethod();
if (temporal && (a_inWorld || a_prepass) && upscaleMethod != Upscaling::UpscaleMethod::kTAA) {
auto renderSize = Util::ConvertToDynamic(screenSize);
if (temporal && upscaleMethod != Upscaling::UpscaleMethod::kTAA) {
auto renderSize = Util::ConvertToDynamic(screenSize, true);
data.MipBias = std::log2f(renderSize.x / screenSize.x);
if (upscaleMethod == Upscaling::UpscaleMethod::kDLSS)
data.MipBias -= 1.0f;
Expand Down