Skip to content

chore: remove skylighting boost in favour of ibl #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doodlum merged 1 commit into from
Sep 8, 2025
Merged

chore: remove skylighting boost in favour of ibl #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package/Shaders/AmbientCompositeCS.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,6 @@ void SampleSSGI(uint2 pixCoord, float3 normalWS, out float ao, out float3 il)

skylightingDiffuse = lerp(1.0, skylightingDiffuse, Skylighting::getFadeOutFactor(positionMS.xyz));

skylightingDiffuse *= 1.0 + saturate(normalWS.z) * (1.0 - SharedData::skylightingSettings.MinDiffuseVisibility);

skylightingDiffuse = Skylighting::mixDiffuse(SharedData::skylightingSettings, skylightingDiffuse);

visibility = skylightingDiffuse;
Expand Down
2 changes: 0 additions & 2 deletions package/Shaders/Lighting.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2761,9 +2761,7 @@ PS_OUTPUT main(PS_INPUT input, bool frontFace : SV_IsFrontFace)
skylightingDiffuse = Skylighting::mixDiffuse(SharedData::skylightingSettings, skylightingDiffuse);

directionalAmbientColor = Color::GammaToLinear(directionalAmbientColor);

directionalAmbientColor *= skylightingDiffuse;
directionalAmbientColor *= 1.0 + saturate(worldNormal.z) * (1.0 - SharedData::skylightingSettings.MinDiffuseVisibility);
directionalAmbientColor = Color::LinearToGamma(directionalAmbientColor);
}
# endif
Expand Down
5 changes: 0 additions & 5 deletions package/Shaders/RunGrass.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,9 +734,7 @@ PS_OUTPUT main(PS_INPUT input, bool frontFace : SV_IsFrontFace)
skylightingDiffuse = Skylighting::mixDiffuse(SharedData::skylightingSettings, skylightingDiffuse);

directionalAmbientColor = Color::GammaToLinear(directionalAmbientColor);

directionalAmbientColor *= skylightingDiffuse;
directionalAmbientColor *= 1.0 + saturate(normal.z) * (1.0 - SharedData::skylightingSettings.MinDiffuseVisibility);
directionalAmbientColor = Color::LinearToGamma(directionalAmbientColor);
}
# endif // SKYLIGHTING
Expand Down Expand Up @@ -925,10 +923,7 @@ PS_OUTPUT main(PS_INPUT input)
skylightingDiffuse = Skylighting::mixDiffuse(SharedData::skylightingSettings, skylightingDiffuse);

directionalAmbientColor = Color::GammaToLinear(directionalAmbientColor);

directionalAmbientColor *= skylightingDiffuse;
directionalAmbientColor *= 1.0 + saturate(normal.z) * (1.0 - SharedData::skylightingSettings.MinDiffuseVisibility);

directionalAmbientColor = Color::LinearToGamma(directionalAmbientColor);
}
# endif // SKYLIGHTING
Expand Down