feat(ui): replace microsoft icons with in-house developed icons. fix action icon scaling. by davo0411 · Pull Request #1315 · community-shaders/skyrim-community-shaders

davo0411 · 2025-07-27T03:28:48Z

changes microsoft icons with in-house developed ones.
applies font size scaling to action icons. this was missed in last pr, which only applied the scaling to category icons.

Summary by CodeRabbit

Bug Fixes
- Improved icon and text scaling in the menu to better adapt to the current font size and UI scale, resulting in more consistent sizing across different display settings.
Chores
- Updated icon file paths for menu actions to use the "Action Icons" directory instead of "Microsoft Icons".
- Removed references and license files related to Microsoft Icons from documentation and package files.

coderabbitai · 2025-07-27T03:28:56Z

Walkthrough

This update removes references to Microsoft Icons and their MIT License from documentation and the codebase, deletes the associated license file, updates icon file paths from "Microsoft Icons" to "Action Icons," and changes icon and text sizing in the menu to be dynamically based on the current font size and UI scale rather than fixed pixel values.

Changes

Files / Paths	Change Summary
README.md	Removed Microsoft Icons reference and MIT License mention from documentation.
.../Icons/Microsoft Icons/LICENSE	Deleted the MIT License file for Microsoft Icons.
src/Utils/UI.cpp	Updated icon file paths and log messages from "Microsoft Icons" to "Action Icons".
src/Menu.cpp	Changed icon and text sizing logic to use dynamic scaling based on font size and UI scale.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Menu
    participant UIUtils

    User->>Menu: Open Settings Menu
    Menu->>UIUtils: Load icon ("Action Icons/...")
    UIUtils-->>Menu: Return icon handle
    Menu->>Menu: Compute icon/text size (font size * scale)
    Menu->>User: Render menu with scaled icons and text

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

chore(ui): fix icon inconsistencies when ui is docked, added watermark #1181: Also modifies Menu::DrawSettings() for icon rendering and scaling, directly affecting the same function and UI behavior.
feat(ui): implement dynamic font scaling based on screen resolution #1233: Changes font size handling in Menu.cpp, showing a related focus on dynamic UI scaling.
feat(ui): add Icon Support #1107: Adds support for loading and displaying icons, modifying the same icon-related files and logic.

Suggested reviewers

doodlum

Poem

A rabbit hops through code so neat,
Swapping icons—old for new,
Dynamic scales for menus sweet,
Licenses trimmed, the docs askew.
With Action Icons now in view,
The UI shines with something fresh—
Hippity-hop, the code’s refreshed! 🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7995755 and 66c3f04.

⛔ Files ignored due to path filters (8)

package/Interface/CommunityShaders/Icons/Action Icons/clear-cache.png is excluded by !**/*.png
package/Interface/CommunityShaders/Icons/Action Icons/load-settings.png is excluded by !**/*.png
package/Interface/CommunityShaders/Icons/Action Icons/restore-settings.png is excluded by !**/*.png
package/Interface/CommunityShaders/Icons/Action Icons/save-settings.png is excluded by !**/*.png
package/Interface/CommunityShaders/Icons/Microsoft Icons/clear-cache.png is excluded by !**/*.png
package/Interface/CommunityShaders/Icons/Microsoft Icons/clear-disk.png is excluded by !**/*.png
package/Interface/CommunityShaders/Icons/Microsoft Icons/load-settings.png is excluded by !**/*.png
package/Interface/CommunityShaders/Icons/Microsoft Icons/save-settings.png is excluded by !**/*.png

📒 Files selected for processing (4)

README.md (0 hunks)
package/Interface/CommunityShaders/Icons/Microsoft Icons/LICENSE (0 hunks)
src/Menu.cpp (3 hunks)
src/Utils/UI.cpp (1 hunks)

💤 Files with no reviewable changes (2)

README.md
package/Interface/CommunityShaders/Icons/Microsoft Icons/LICENSE

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: alandtse
PR: doodlum/skyrim-community-shaders#0
File: :0-0
Timestamp: 2025-06-24T07:17:36.604Z
Learning: When reviewing PRs, always clarify the scope if there are multiple related features or dependencies. WeatherPicker was a separate PR that was already merged, while this PR focuses specifically on WetnessEffects climate preset system enhancements.

Learnt from: alandtse
PR: doodlum/skyrim-community-shaders#0
File: :0-0
Timestamp: 2025-07-05T05:20:45.823Z
Learning: In the skyrim-community-shaders repository, file deletion error handling improvements that replace existence checks and try-catch blocks with std::filesystem::remove error-code-based approaches are considered bug fixes rather than refactoring, as they address inadequate error handling and misleading log messages.

Learnt from: davo0411
PR: doodlum/skyrim-community-shaders#1107
File: src/Menu.cpp:310-315
Timestamp: 2025-05-31T02:51:24.195Z
Learning: In the Community Shaders codebase, when validating UI icons, checking for texture presence (non-null pointer) is sufficient. Avoid adding dimension validation checks as icon sizes should vary based on user needs (4K+ resolution users may want higher resolution icons). Don't artificially limit icon dimensions.

src/Utils/UI.cpp (1)

Learnt from: davo0411
PR: #1107
File: src/Menu.cpp:310-315
Timestamp: 2025-05-31T02:51:24.195Z
Learning: In the Community Shaders codebase, when validating UI icons, checking for texture presence (non-null pointer) is sufficient. Avoid adding dimension validation checks as icon sizes should vary based on user needs (4K+ resolution users may want higher resolution icons). Don't artificially limit icon dimensions.

src/Menu.cpp (1)

Learnt from: davo0411
PR: #1107
File: src/Menu.cpp:310-315
Timestamp: 2025-05-31T02:51:24.195Z
Learning: In the Community Shaders codebase, when validating UI icons, checking for texture presence (non-null pointer) is sufficient. Avoid adding dimension validation checks as icon sizes should vary based on user needs (4K+ resolution users may want higher resolution icons). Don't artificially limit icon dimensions.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build plugin and addons

🔇 Additional comments (6)

src/Utils/UI.cpp (3)

194-200: LGTM! Clean icon path migration for save-settings.

The path update from "Microsoft Icons" to "Action Icons" is correctly implemented with consistent logging messages.

203-209: LGTM! Consistent icon path migration for load-settings.

The path update maintains consistency with the save-settings icon changes and properly updates all related log messages.

212-218: LGTM! Completes the consistent icon path migration for clear-cache.

All three action icons now consistently use the "Action Icons" directory, completing the migration away from Microsoft Icons as intended.

src/Menu.cpp (3)

397-398: LGTM! Excellent improvement to dynamic icon sizing in docked mode.

The change from fixed pixel sizes to font-size-relative scaling (currentFontSize * 1.25f * uiScale) ensures icons scale appropriately with user's font and UI scale settings, providing a much more consistent user experience.

448-450: LGTM! Consistent dynamic sizing for undocked mode icons.

The font-size-relative scaling (currentFontSize * 1.5f) maintains consistency with the docked mode approach while providing appropriate sizing for the undocked UI context.

529-532: LGTM! Completes the consistent dynamic sizing implementation for logo.

The logo now scales with the same font-size-relative approach (currentFontSize * 1.5f) as other undocked icons, ensuring visual consistency across the entire UI.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.

github-actions · 2025-07-27T03:30:13Z

Using provided base ref: 7995755
Using base ref: 7995755
Base commit date: 2025-07-27T02:15:45+01:00 (Sunday, July 27, 2025 02:15 AM)
No actionable suggestions for changed features.

github-actions · 2025-07-27T03:47:38Z

✅ A pre-release build is available for this PR:
Download

davo0411 added 3 commits July 27, 2025 11:47

Swap to better action icons

4b0f6f0

Fix action icon scaling with font size metric

e820ed3

Update Menu.cpp

3130748

style: 🎨 apply pre-commit.ci formatting

66c3f04

Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.

doodlum approved these changes Jul 27, 2025

View reviewed changes

doodlum merged commit ff040be into community-shaders:dev Jul 27, 2025
15 checks passed

davo0411 deleted the icon-replacemennts branch July 27, 2025 11:03

This was referenced Sep 9, 2025

feat(ui): display category and icon #1455

Merged

feat(ui): update icons and rename "Load Settings" #1473

Merged

coderabbitai Bot mentioned this pull request Nov 26, 2025

feat(ui): add themes & fonts #1596

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): replace microsoft icons with in-house developed icons. fix action icon scaling.#1315

feat(ui): replace microsoft icons with in-house developed icons. fix action icon scaling.#1315
doodlum merged 4 commits into
community-shaders:devfrom
davo0411:icon-replacemennts

davo0411 commented Jul 27, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 27, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions Bot commented Jul 27, 2025

Uh oh!

github-actions Bot commented Jul 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

davo0411 commented Jul 27, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions Bot commented Jul 27, 2025

Uh oh!

github-actions Bot commented Jul 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

davo0411 commented Jul 27, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 27, 2025 •

edited

Loading