Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen fixes #587

Merged
merged 18 commits into from
Sep 7, 2022
Merged

Codegen fixes #587

merged 18 commits into from
Sep 7, 2022

Conversation

tetron
Copy link
Member

@tetron tetron commented Aug 26, 2022

Work in progress. Fixing things to make the "fast validation" path in cwltool work.

@tetron
Copy link
Member Author

tetron commented Aug 26, 2022

Also currently missing from codegen is link checking.

@lgtm-com
Copy link

lgtm-com bot commented Aug 26, 2022

This pull request introduces 1 alert and fixes 1 when merging 067d3a0 into 2c58ed3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Aug 27, 2022

This pull request introduces 1 alert and fixes 1 when merging b5d99ae into 2c58ed3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Aug 29, 2022

This pull request introduces 1 alert and fixes 1 when merging c5886dc into 2c58ed3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Aug 29, 2022

This pull request introduces 1 alert and fixes 1 when merging 5804316 into 2c58ed3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Aug 30, 2022

This pull request introduces 1 alert and fixes 1 when merging 626bd20 into 2c58ed3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #587 (66534ab) into main (f46b257) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
+ Coverage   83.08%   83.14%   +0.05%     
==========================================
  Files          20       20              
  Lines        3950     3952       +2     
  Branches     1104     1104              
==========================================
+ Hits         3282     3286       +4     
+ Misses        432      431       -1     
+ Partials      236      235       -1     
Impacted Files Coverage Δ
schema_salad/codegen.py 94.05% <100.00%> (+1.90%) ⬆️
schema_salad/python_codegen.py 93.45% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tetron tetron marked this pull request as ready for review August 30, 2022 00:48
@lgtm-com
Copy link

lgtm-com bot commented Aug 30, 2022

This pull request introduces 1 alert and fixes 1 when merging c5a22c9 into 2c58ed3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2022

This pull request introduces 1 alert and fixes 1 when merging 0377d0c into 122fd5d - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2022

This pull request introduces 1 alert and fixes 1 when merging cda83a0 into 41eb3a5 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2022

This pull request introduces 1 alert and fixes 1 when merging 63ae75a into 41eb3a5 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2022

This pull request introduces 1 alert and fixes 1 when merging 66534ab into f46b257 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@mr-c mr-c merged commit 9995bfd into main Sep 7, 2022
@mr-c mr-c deleted the codegen-fixes branch September 7, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants