Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen changes to support cwltool --fast-parse #156

Merged
merged 5 commits into from
Sep 7, 2022
Merged

Codegen changes to support cwltool --fast-parse #156

merged 5 commits into from
Sep 7, 2022

Conversation

tetron
Copy link
Member

@tetron tetron commented Aug 31, 2022

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AttributeError: 'LoadingOptions' object has no attribute 'original_doc'

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2022

This pull request introduces 1 alert when merging c889cf2 into 5a00d2c - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2022

This pull request introduces 1 alert when merging 346cbd5 into 5a00d2c - view on LGTM.com

new alerts:

  • 1 for Unused import

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the outputSource refscope fix broke the expression refactoring tool

cwl_utils.errors.WorkflowException: param out1 not found in class: Workflow

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2022

This pull request introduces 1 alert when merging 84c51ee into 5a00d2c - view on LGTM.com

new alerts:

  • 1 for Unused import

@mr-c mr-c marked this pull request as draft August 31, 2022 17:31
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #156 (a7641fd) into main (53a129b) will increase coverage by 0.59%.
The diff coverage is 50.00%.

❗ Current head a7641fd differs from pull request most recent head d028dff. Consider uploading reports for the commit d028dff to get more accurate results

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   29.53%   30.13%   +0.59%     
==========================================
  Files          28       28              
  Lines       20763    21541     +778     
  Branches     5775     5981     +206     
==========================================
+ Hits         6133     6491     +358     
- Misses      13301    13627     +326     
- Partials     1329     1423      +94     
Impacted Files Coverage Δ
cwl_utils/cite_extract.py 53.33% <0.00%> (ø)
cwl_utils/docker_extract.py 50.00% <0.00%> (-7.15%) ⬇️
cwl_utils/parser/cwl_v1_0.py 30.45% <ø> (+1.08%) ⬆️
cwl_utils/parser/cwl_v1_1.py 27.44% <ø> (+1.10%) ⬆️
cwl_utils/parser/cwl_v1_2.py 29.58% <ø> (+0.82%) ⬆️
cwl_utils/cwl_v1_2_expression_refactor.py 33.19% <50.00%> (ø)
cwl_utils/expression_refactor.py 80.48% <100.00%> (ø)
cwl_utils/parser/__init__.py 71.13% <100.00%> (ø)
cwl_utils/image_puller.py 43.07% <0.00%> (-43.08%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2022

This pull request introduces 1 alert when merging a154797 into 5a00d2c - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2022

This pull request introduces 1 alert when merging 4d1b211 into 53a129b - view on LGTM.com

new alerts:

  • 1 for Unused import

@mr-c mr-c marked this pull request as ready for review September 7, 2022 16:54
@mr-c mr-c changed the title Codegen fixes Codegen changes to support cwltool --fast-parse Sep 7, 2022
@mr-c mr-c enabled auto-merge (squash) September 7, 2022 17:27
@mr-c mr-c merged commit abe61c8 into main Sep 7, 2022
@mr-c mr-c deleted the codegen-fixes branch September 7, 2022 17:28
@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2022

This pull request introduces 1 alert when merging d028dff into 53a129b - view on LGTM.com

new alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants