Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(storybook): migrate to v7 - part 1 #2689

Merged
merged 10 commits into from
Feb 8, 2024
Merged

refactor(storybook): migrate to v7 - part 1 #2689

merged 10 commits into from
Feb 8, 2024

Conversation

kark
Copy link
Contributor

@kark kark commented Jan 16, 2024 •
edited
Loading

Summary

This pull request migrates the initial set of Storybook stories for the Tooltip, ViewSwitcher, ErrorMessage, and WarningMessage components

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d80d641

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ❌ Failed (Inspect) Feb 8, 2024 11:53am

@vercel vercel bot requested a deployment to Preview January 16, 2024 15:38 Abandoned
kark
kark commented Jan 17, 2024
View reviewed changes
packages/components/messages/src/error-message/README.mdx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Readmes for ErrorMessage and WarningMessage have been split to accommodate the constraint of having only one <Meta>.

packages/components/view-switcher/src/view-switcher.stories.tsx Outdated Show resolved Hide resolved
@CarlosCortizasCT CarlosCortizasCT mentioned this pull request Feb 7, 2024
Merged
@CarlosCortizasCT
[Storybook migration] ViewSwitcher alternative proposal (#2715)
bbb7b96 
* refactor(view-switcher): alternative stories implementation proposal

* refactor(view-switcher): little improvement

* refactor(view-switcher): remove unnecessary ts type prop
@kark
refactor: improvements
75cb5e4 
refactor: cleanup
CarlosCortizasCT
CarlosCortizasCT approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all the work and the discussions around this first chunk of stories migration 👏 👏 👏 👏

I think we're setting some good best practices for the next migration work.

Super excited to see this moving forward 🔝

@kark kark merged commit 7529c6d into cm-update-storybook Feb 8, 2024
1 of 3 checks passed
@kark kark deleted the SHIELD-1028-storybook-migration-part1 branch February 8, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

@ddouglasz ddouglasz Awaiting requested review from ddouglasz

@chloe0592 chloe0592 Awaiting requested review from chloe0592

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kark @CarlosCortizasCT