feat(application-page-title): remove case transformations in browser tab title #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 235a14f The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…or custom application template starter test
Rhotimee
approved these changes
Sep 5, 2024
mustafaasif2
changed the title
kark
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Thanks, I've seen a comment that we're not considering that a breaking change so it looks good to me.
We probably need to update the docs as well
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The case transformations in the browser tab title component were removed. This affects all the custom and native applications.
Description
The custom application "commercetools Checkout" was displaying "Commercetools-checkout" in the browser tab title, with the first letter of "commercetools" incorrectly capitalized. This issue stemmed from intentional case transformations in the
ApplicationPageTitlecomponent.To address this, the case transformations in the getPageTitle function were removed to ensure that all the custom and native applications remains in lowercase as required.
Corresponding ticket: SHIELD-1092