fix(app-shell): feature flags for menu to not use launchdarkly

[tdeekens]

Summary

We have two adapters in flopflip: one for LaunchDarkly and one for our GraphQL endpoint. The first acts lazy and the latter eager.

When we pass the menu flags to LaunchDarkly's adapter, they will be used to build a subscriptions to LaunchDarkly and then be persisted as a in the cache of the adapter. The value then cached is false (as the default). This means the menu item will not show unless the page is reloaded until the cache updates. This is cause the default value from the cache is used as LaunchDarkly has precedence over the MC API flags.

In short: we should not use LaunchDarkly to toggle menu visibility. In fact no team right now does. Instead we should use the MC API. For this to work eagerly (menu items show without reloading) we need to have the MC API adapter have precedence not the LaunchDarkly adapter.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mc-app-kit-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 30, 2024 9:57am
merchant-center-application-kit-components-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 30, 2024 9:57am

[changeset-bot]

🦋 Changeset detected

Latest commit: 452273a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages

Name	Type
@commercetools-frontend/application-shell	Patch
@commercetools-frontend/cypress	Patch
@commercetools-applications/merchant-center-template-starter-typescript	Patch
@commercetools-applications/merchant-center-template-starter	Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript	Patch
@commercetools-applications/merchant-center-custom-view-template-starter	Patch
@commercetools-local/playground	Patch
@commercetools-local/visual-testing-app	Patch
@commercetools-backend/eslint-config-node	Patch
@commercetools-backend/express	Patch
@commercetools-backend/loggers	Patch
@commercetools-frontend/actions-global	Patch
@commercetools-frontend/application-components	Patch
@commercetools-frontend/application-config	Patch
@commercetools-frontend/application-shell-connectors	Patch
@commercetools-frontend/assets	Patch
@commercetools-frontend/babel-preset-mc-app	Patch
@commercetools-frontend/browser-history	Patch
@commercetools-frontend/codemod	Patch
@commercetools-frontend/constants	Patch
@commercetools-frontend/create-mc-app	Patch
@commercetools-frontend/eslint-config-mc-app	Patch
@commercetools-frontend/i18n	Patch
@commercetools-frontend/jest-preset-mc-app	Patch
@commercetools-frontend/jest-stylelint-runner	Patch
@commercetools-frontend/l10n	Patch
@commercetools-frontend/mc-dev-authentication	Patch
@commercetools-frontend/mc-html-template	Patch
@commercetools-frontend/mc-scripts	Patch
@commercetools-frontend/notifications	Patch
@commercetools-frontend/permissions	Patch
@commercetools-frontend/react-notifications	Patch
@commercetools-frontend/sdk	Patch
@commercetools-frontend/sentry	Patch
@commercetools-frontend/url-utils	Patch
@commercetools-website/components-playground	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[kark]

Thank you 😊