-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Azure as a new MC target in configuration #3558
Conversation
🦋 Changeset detectedLatest commit: 397fa78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR is missing a Jira ticket reference in the title or description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to map the values in the code:
- for the application config:
const mapCloudIdentifierToApiUrl = ( key: (typeof CLOUD_IDENTIFIERS)[keyof typeof CLOUD_IDENTIFIERS] ): string => { switch (key) { case CLOUD_IDENTIFIERS.GCP_AU: return MC_API_URLS.GCP_AU; case CLOUD_IDENTIFIERS.GCP_EU: return MC_API_URLS.GCP_EU; case CLOUD_IDENTIFIERS.GCP_US: return MC_API_URLS.GCP_US; case CLOUD_IDENTIFIERS.AWS_FRA: return MC_API_URLS.AWS_FRA; case CLOUD_IDENTIFIERS.AWS_OHIO: return MC_API_URLS.AWS_OHIO; case CLOUD_IDENTIFIERS.AWS_CN: return MC_API_URLS.AWS_CN; default: // We would probably never get to this point, as the JSON schema validation // kicks in before. throw new Error( `Unknown cloud identifier "${key}". Supported values: ${Object.values( CLOUD_IDENTIFIERS ).toString()}` ); } }; - in the express middleware:
merchant-center-application-kit/packages-backend/express/src/auth.ts
Lines 54 to 73 in 8c10dd8
const mapCloudIdentifierToIssuer = <Request extends TBaseRequest>( issuer: TSessionMiddlewareOptions<Request>['issuer'] ): string | undefined => { switch (issuer) { case CLOUD_IDENTIFIERS.GCP_AU: return MC_API_URLS.GCP_AU; case CLOUD_IDENTIFIERS.GCP_EU: return MC_API_URLS.GCP_EU; case CLOUD_IDENTIFIERS.GCP_US: return MC_API_URLS.GCP_US; case CLOUD_IDENTIFIERS.AWS_FRA: return MC_API_URLS.AWS_FRA; case CLOUD_IDENTIFIERS.AWS_OHIO: return MC_API_URLS.AWS_OHIO; case CLOUD_IDENTIFIERS.AWS_CN: return MC_API_URLS.AWS_CN; default: return undefined; } };
Updated here: 397fa78 |
🥷 Code experts: emmenko emmenko has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
Summary
Include Azure as a new MC target in configuration.
Description
We add a new configuration option for Custom Applications and Custom Views so they can set the upcoming Azure production environment as a target.