refactor: change http-adapter to eager mode #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ed7f8c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This PR is missing a Jira ticket reference in the title or description. |
|
🥷 Code experts: emmenko tdeekens, emmenko have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
Merged
ddouglasz
pushed a commit
that referenced
this pull request
Jun 17, 2024
* refactor: change http-adapter to eager mode * Create cold-lemons-whisper.md * fix: ts-ignore comment position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've been to lazy and should be more eager.
Description
After a lot of communication and alignment we realized that being eager on the http-adapter helps drive user expectations.
The background is that we toggle functionality through the http-adapter which is generally available to users. Having a "delayed" appearing through a reload for these functionalities is not ideal. It's acceptable for anything which sits behind LaunchDarkly and there has also the benefit to avoid the flicker.
Followings
The general storyline is also to get flopflip ready for React Suspense finally when time permits.