Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom Views issues #3343

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Fix Custom Views issues #3343

merged 5 commits into from
Dec 13, 2023

Conversation

CarlosCortizasCT
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT commented Dec 12, 2023

Summary

In this PR we're tackling some last minute issues found around Custom Views rendering.

Description

These are the issues addressed in this PR:

  • Unstyled Page Layout components when rendered within a Custom View
  • Routing issues when navigating within a Custom View
  • Custom View not including PortalsContainer component (required for modals, dialogs,...).

Regarding the last point, I included the component so it does not break the Custom View if a Dialog, Modal is used, but I don't think this is the solution we want.

Here's an example of how it looks like:

Screenshot 2023-12-12 at 20 51 46

I think it would be better for Custom Views to have a different mechanism for modals and dialogs that we should discuss.

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 3e14d51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/cypress Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-website/custom-applications Patch
@commercetools-website/custom-views Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-bos7z45r7-commercetools.vercel.app
https://appkit-sha-ba08069e4bd301d43d37a998015e598cbce686a0.commercetools.vercel.app
https://appkit-pr-3343.commercetools.vercel.app

Built with commit 3e14d51.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Deploy preview for application-kit-custom-views ready!

✅ Preview
https://application-kit-custom-views-r53k3kxx1-commercetools.vercel.app
https://appkit-cv-sha-ba08069e4bd301d43d37a998015e598cbce686a0.commercetools.vercel.app
https://appkit-cv-pr-3343.commercetools.vercel.app

Built with commit 3e14d51.
This pull request is being automatically deployed with vercel-action

Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes fix the issues as expected 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants