-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Custom Views issues #3343
Fix Custom Views issues #3343
Conversation
…n used within custom views
🦋 Changeset detectedLatest commit: 3e14d51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit 3e14d51. |
Deploy preview for application-kit-custom-views ready! ✅ Preview Built with commit 3e14d51. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, changes fix the issues as expected 💯
Summary
In this PR we're tackling some last minute issues found around Custom Views rendering.
Description
These are the issues addressed in this PR:
PortalsContainer
component (required for modals, dialogs,...).Regarding the last point, I included the component so it does not break the Custom View if a
Dialog
,Modal
is used, but I don't think this is the solution we want.Here's an example of how it looks like:
I think it would be better for Custom Views to have a different mechanism for modals and dialogs that we should discuss.