Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow drawer to expand height with a scrollbar #3331

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

YahiaElTai
Copy link
Contributor

When I first added the drawer, I added it with a bug sadly.

When the drawer has long content the scrollbar doesn't appear to allow the user to see the content in the bottom of the drawer. This PR fixes that by adopting the same behavior from the higher level modal components

@YahiaElTai YahiaElTai added the 🙏 Status: Dev Review Waiting for technical reviews label Dec 6, 2023
@YahiaElTai YahiaElTai self-assigned this Dec 6, 2023
Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: adbc226

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch
@commercetools-frontend/cypress Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-website/custom-applications Patch
@commercetools-website/custom-views Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-gi8pivejy-commercetools.vercel.app
https://appkit-sha-e65aed05916b3d757510f8cf5967d2ebf32b926e.commercetools.vercel.app
https://appkit-pr-3331.commercetools.vercel.app

Built with commit adbc226.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Deploy preview for application-kit-custom-views ready!

✅ Preview
https://application-kit-custom-views-kx6qc4pxg-commercetools.vercel.app
https://appkit-cv-sha-e65aed05916b3d757510f8cf5967d2ebf32b926e.commercetools.vercel.app
https://appkit-cv-pr-3331.commercetools.vercel.app

Built with commit adbc226.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@kark kark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch! Everything looks good to me.
Would you mind adding a changeset, please? 🙏

Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@kark kark merged commit 7e62ee1 into main Dec 7, 2023
20 checks passed
@kark kark deleted the yt-fix-drawer branch December 7, 2023 11:16
@ct-changesets ct-changesets bot mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 Status: Dev Review Waiting for technical reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants