-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow drawer to expand height with a scrollbar #3331
Conversation
🦋 Changeset detectedLatest commit: adbc226 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit adbc226. |
Deploy preview for application-kit-custom-views ready! ✅ Preview Built with commit adbc226. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch! Everything looks good to me.
Would you mind adding a changeset, please? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 💯
When I first added the drawer, I added it with a bug sadly.
When the drawer has long content the scrollbar doesn't appear to allow the user to see the content in the bottom of the drawer. This PR fixes that by adopting the same behavior from the higher level modal components