Fix Custom Views panel UI #3322
Conversation
🦋 Changeset detectedLatest commit: 4617238 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -130,21 +136,24 @@ function CustomViewLoader(props: TCustomViewLoaderProps) { | |||
| ].join('/'); | |||
|
|
|||
| return ( | |||
| <Drawer | |||
| <ModalPage | |||
There was a problem hiding this comment.
This is the file with the relevant changes.
|
Deploy preview for application-kit-custom-views ready! ✅ Preview Built with commit 4617238. |
|
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit 4617238. |
| onClose={props.onClose} | ||
| size={panelSize === 'small' ? 10 : 30} | ||
| title="" |
There was a problem hiding this comment.
Shouldn't we provide a title here?
There was a problem hiding this comment.
The issue is that the title is required in the ModalPage component and I didn't want to change that but we don't want to display any title in this use case.
There was a problem hiding this comment.
The title of the ModalPage is only used for accessibility if I'm not mistaken, it's not a visible value.
There was a problem hiding this comment.
So are you suggesting we should make that property optional in the ModalPage component?
...application-components/src/components/custom-views/custom-view-loader/custom-view-loader.tsx
Show resolved
Hide resolved
Summary
Fix Custom Views panel UI
Description
We realized we broke the UI of the Custom Views panel container when working in the new
Drawercomponent so, instead of having a clean container with no predefined header:we were including a non-wanted header:
On top of that, I took the opportunity to update
@emotion/reactdependency to match the one used inui-kit.