Add extra container in top nav for portal #3300
Conversation
🦋 Changeset detectedLatest commit: f8741cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jaikumar-tj
changed the title
| display: flex; | ||
| `} | ||
| > | ||
| <div id="extra-menu"></div> |
There was a problem hiding this comment.
please suggest a better id or data-test name
There was a problem hiding this comment.
Also should it have a margin here or can it remain in mc-frontend instead where the portal is used?
There was a problem hiding this comment.
- Naming
Given here on the prior PR we didn't introduce a staff-bar--main or something name dedicated to the usage we could maybe name this left-of-profile? Just as a suggestion?
- Margin
I would not specify the margin here but define it in the MC FE. Maybe using spacer components.
Always found this a good article on the subject https://mxstbr.com/thoughts/margin/
|
FYI @chloe0592 I assume you were also trying to resolve this position issue. we discussed and decided that having an extra container would be better since the shield team can move it according to their new design independently. |
|
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit f8741cb. |
|
Deploy preview for application-kit-custom-views ready! ✅ Preview Built with commit f8741cb. |
| display: flex; | ||
| `} | ||
| > | ||
| <div id="extra-menu"></div> |
There was a problem hiding this comment.
Nit: I would define the ID here:
| display: flex; | ||
| `} | ||
| > | ||
| <div id="extra-menu"></div> |
Summary
Creating a empty container in top-navigation panel for staffbar team switcher to display the
limited permissionstamp using portal.