Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow TypedDocumentNode as a type for query and mutation params in MC Apollo hooks #3269

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

ragafus
Copy link
Contributor

@ragafus ragafus commented Oct 13, 2023

Summary

useMcQuery, useMcLazyQuery and useMcMutation accept a TypedDocumentNode as query/mutation param.

Description

The goal of this PR is to unblock projects where @commercetools-frontend/application-shell-connectors is used and start using TypedDocumentNode.
The idea is to test TypedDocumentNode in the Standalone Prices web app and check if it improves DX by reducing the amount of boilerplate code needed to use the hooks.

@ragafus ragafus self-assigned this Oct 13, 2023
@ragafus ragafus changed the title feat: allow TypedDocumentNode as a type for query and mutation para… feat: allow TypedDocumentNode as a type for query and mutation params in MC Apollo hooks Oct 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: 97916d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/application-shell-connectors Minor
@commercetools-frontend/application-components Minor
@commercetools-frontend/application-shell Minor
@commercetools-frontend/permissions Minor
@commercetools-applications/merchant-center-template-starter-typescript Minor
@commercetools-applications/merchant-center-template-starter Minor
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Minor
@commercetools-local/playground Minor
@commercetools-local/visual-testing-app Minor
@commercetools-frontend/codemod Minor
@commercetools-frontend/mc-scripts Minor
@commercetools-website/components-playground Minor
@commercetools-frontend/cypress Minor
@commercetools-backend/eslint-config-node Minor
@commercetools-backend/express Minor
@commercetools-backend/loggers Minor
@commercetools-frontend/actions-global Minor
@commercetools-frontend/application-config Minor
@commercetools-frontend/assets Minor
@commercetools-frontend/babel-preset-mc-app Minor
@commercetools-frontend/browser-history Minor
@commercetools-frontend/constants Minor
@commercetools-frontend/create-mc-app Minor
@commercetools-frontend/eslint-config-mc-app Minor
@commercetools-frontend/i18n Minor
@commercetools-frontend/jest-preset-mc-app Minor
@commercetools-frontend/jest-stylelint-runner Minor
@commercetools-frontend/l10n Minor
@commercetools-frontend/mc-dev-authentication Minor
@commercetools-frontend/mc-html-template Minor
@commercetools-frontend/notifications Minor
@commercetools-frontend/react-notifications Minor
@commercetools-frontend/sdk Minor
@commercetools-frontend/sentry Minor
@commercetools-frontend/url-utils Minor
@commercetools-website/custom-applications Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-89sqbr2wd-commercetools.vercel.app
https://appkit-sha-94e176686afe4d09361881e0d5062ac01d5aa6c4.commercetools.vercel.app
https://appkit-pr-3269.commercetools.vercel.app

Built with commit 97916d6.
This pull request is being automatically deployed with vercel-action

@ragafus ragafus marked this pull request as ready for review October 13, 2023 15:11
@ragafus ragafus merged commit 6398b19 into main Oct 17, 2023
14 checks passed
@ragafus ragafus deleted the rg-shell-apollo-hooks branch October 17, 2023 11:40
@ct-changesets ct-changesets bot mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants