Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mc-scripts): allow to load a custom Vite config #2630

Merged
merged 1 commit into from
Jun 3, 2022
Merged

refactor(mc-scripts): allow to load a custom Vite config #2630

merged 1 commit into from
Jun 3, 2022

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented May 30, 2022

Ref #2577

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2022

🦋 Changeset detected

Latest commit: 3a72586

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@commercetools-frontend/mc-scripts Patch
merchant-center-application-template-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview May 30, 2022 08:02 Destroyed
@github-actions
Copy link
Contributor

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-ieyhaz1r8-commercetools.vercel.app
https://appkit-sha-4cd7e9f78511a6ded82226bafca7767dcee52e27.commercetools.vercel.app
https://appkit-pr-2630.commercetools.vercel.app

Built with commit 3a72586.
This pull request is being automatically deployed with vercel-action

@emmenko emmenko marked this pull request as ready for review June 3, 2022 09:49
@emmenko emmenko requested review from tdeekens and a team June 3, 2022 09:49
CarlosCortizasCT
CarlosCortizasCT reviewed Jun 3, 2022
View reviewed changes
.changeset/lazy-beds-matter.md

> These changes are only relevant when using the experimental Vite bundler (`ENABLE_EXPERIMENTAL_VITE_BUNDLER=true`).

Allow to load a Vite config in addition to the default config. This is useful for using extra Rollup/Vite plugins, or other Vite options.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now if users want to use a custom config file they just need to create a vite.config.js in the root directory of their application?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's the idea.

@emmenko emmenko merged commit c0516c5 into main Jun 3, 2022
@emmenko emmenko deleted the nm-custom-vite-config branch June 3, 2022 12:43
@ghost ghost mentioned this pull request Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

@tdeekens tdeekens tdeekens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmenko @tdeekens @CarlosCortizasCT