refactor(application-components): add optional prop to modal page transform property #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 44ba8d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/Gs7owBfjrYvnbCQJxNVPLaXsTZS2 |
emmenko
requested changes
Nov 8, 2021
packages/application-components/src/components/modal-pages/internals/modal-page.tsx
Outdated
Show resolved
Hide resolved
|
Asides @emmenko's suggestions & the changeset, looks okay. |
emmenko
reviewed
Nov 9, 2021
packages/application-components/src/components/modal-pages/internals/modal-page.tsx
Outdated
Show resolved
Hide resolved
emmenko
reviewed
Nov 9, 2021
.../application-components/src/components/modal-pages/tabular-modal-page/tabular-modal-page.mdx
Outdated
Show resolved
Hide resolved
fuchodeveloper
added
the
🚀 Status: ship it
Rhotimee
reviewed
Nov 10, 2021
...tion-components/src/components/modal-pages/custom-form-modal-page/custom-form-modal-page.tsx
Outdated
Show resolved
Hide resolved
emmenko
approved these changes
Nov 10, 2021
Rhotimee
approved these changes
Nov 10, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional prop (
afterOpenStyles) toModalPagecomponentDescription
The
<*ModalPage>components now accept a propafterOpenStylesto overwrite the default styles. You can pass a "class name" or a CSS-in-JS style object.This fixes a
jumpybehavior observed when attempting to drag-n-drop an element on a modal page.