Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mc-scripts): dotenv path resolution, remove experimental --match flag #2196

Merged
merged 1 commit into from
May 6, 2021

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented May 6, 2021

The --match flag is not that helpful at the end, because you would then need to provide the dotenv files etc.

PS: I think that prompting for packages could be something more suited for something else like @manypkg.

@vercel
Copy link

vercel bot commented May 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/5VTq3ptQaFWX6QkJ93zpPoWUAEKT
✅ Preview: https://merchant-cente-git-nm-mc-scripts-remove-match-commer-099c4f.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2021

🦋 Changeset detected

Latest commit: 41e5279

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools-frontend/mc-scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmenko emmenko requested a review from adnasa May 6, 2021 14:06
Copy link
Contributor

@adnasa adnasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@emmenko emmenko merged commit a2f6732 into main May 6, 2021
@emmenko emmenko deleted the nm-mc-scripts-remove-match branch May 6, 2021 14:13
@ghost ghost mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants