Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): remove unnecessary apollo client dependency #2056

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Feb 15, 2021

I guess this was a leftover from removing the "experimental" entry point from the components package.

@vercel
Copy link

vercel bot commented Feb 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/a2uv505xu
✅ Preview: https://merchant-center-application-kit-git-nm-remove-unnecessary-dep.commercetools.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2021

🦋 Changeset detected

Latest commit: 8a3b1bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@commercetools-frontend/application-components Patch
merchant-center-application-template-starter Patch
@commercetools-frontend/application-shell Patch
playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/components-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmenko emmenko requested a review from adnasa February 15, 2021 09:55
@@ -31,7 +31,6 @@
"prepare": "./../../scripts/version.js replace"
},
"dependencies": {
"@apollo/client": "3.3.8",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: in the other packages where we do use it, it's declared as a peer dependency

Copy link
Contributor

@adnasa adnasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@adnasa
Copy link
Contributor

adnasa commented Feb 15, 2021

I guess this was a leftover from removing the "experimental" entry point from the components package.

good catch. yes it was

@emmenko emmenko merged commit e574311 into main Feb 15, 2021
@emmenko emmenko deleted the nm-remove-unnecessary-dep branch February 15, 2021 10:13
@ghost ghost mentioned this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants