feat(components): add <PublicPageLayout> component #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/o0zlmj67y |
🦋 Changeset detectedLatest commit: 1cdf6aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emmenko
commented
Jan 15, 2021
Comment on lines
+9
to
+10
| // https://babeljs.io/blog/2017/09/11/zero-config-with-babel-macros | ||
| import base64Background from /* preval */ './public-background'; |
tdeekens
reviewed
Jan 18, 2021
| it('should render welcome message and footer', async () => { | ||
| renderComponent( | ||
| <PublicPageLayout welcomeMessage="Welcome to the Merchant Center"> | ||
| {'Test'} |
There was a problem hiding this comment.
Nit: should this work?
Suggested change
| {'Test'} | |
| Test |
tdeekens
reviewed
Jan 18, 2021
Comment on lines
+9
to
+10
| // https://babeljs.io/blog/2017/09/11/zero-config-with-babel-macros | ||
| import base64Background from /* preval */ './public-background'; |
| /** | ||
| * The `normal` scale uses an horizontal contraint size of `8` (384px). | ||
| * The `wide` scale uses an horizontal contraint size of `15` (742px). | ||
| * The `wide` scale can be used for |
visual-testing-app/src/components/public-page-form-wide/public-page-form-wide.visualroute.tsx
Show resolved
Hide resolved
adnasa
approved these changes
Jan 18, 2021
tdeekens
approved these changes
Jan 18, 2021
tdeekens
approved these changes
Jan 18, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new layout component (essentially our internal "public page container" component).
This is useful for login pages (or other pages such as auth callback error page #1934 ).