Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mc-scripts/extract-intl): fix console warning #1703

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

mohib0306
Copy link
Contributor

Summary

  • mc-scripts/extract-intl => fix the wrong usage of console warning. Replaced console.warning with console.warn

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2020

🦋 Changeset is good to go

Latest commit: 45a005e

We got this.

This PR includes changesets to release 4 packages
Name Type
@commercetools-frontend/mc-scripts Patch
merchant-center-application-template-starter Patch
playground Patch
@commercetools-local/visual-testing-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/d3r0jmv45
✅ Preview: https://merchant-center-application-kit-git-mw-fix-extract-intl-script.commercetools.vercel.app

@mohib0306 mohib0306 self-assigned this Aug 26, 2020
@mohib0306 mohib0306 requested a review from emmenko August 26, 2020 12:38
@mohib0306 mohib0306 added the 🐛 Type: Bug Something isn't working label Aug 26, 2020
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😅

@emmenko
Copy link
Member

emmenko commented Aug 26, 2020

Don't forget the changeset

@vercel vercel bot temporarily deployed to Preview August 26, 2020 12:55 Inactive
@mohib0306 mohib0306 added the 🚀 Status: ship it Triggers an merge if rules match via bot label Aug 26, 2020
@kodiakhq kodiakhq bot merged commit 9d62b85 into master Aug 26, 2020
@kodiakhq kodiakhq bot deleted the mw-fix-extract-intl-script branch August 26, 2020 13:21
@ghost ghost mentioned this pull request Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Status: ship it Triggers an merge if rules match via bot 🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants