Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency css-loader to v4 #1655

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 27, 2020

This PR contains the following updates:

Package Type Update Change
css-loader dependencies major 3.6.0 -> 4.0.0

Release Notes

webpack-contrib/css-loader

v4.0.0

Compare Source

⚠ BREAKING CHANGES
  • minimum required Node.js version is 10.13.0
  • minimum required webpack version is 4.27.0
  • the esModule option is true by default
  • default value of the sourceMap option depends on the devtool option
  • icss plugin disable by default, you need to setup the modules option to enable it
  • the modules option is true by default for all files matching /\.module\.\w+$/i.test(filename) regular expression, module.auto is true by default
  • the modules.context option was renamed to the modules.localIdentContext option
  • default the modules.localIdentContext value is compiler.context for the module.getLocalIdent option
  • the modules.hashPrefix option was renamed to the modules.localIdentHashPrefix option
  • the localsConvention option was moved and renamed to the modules.exportLocalsConvention option
  • the getLocalIndent option should be always Function and should always return String value
  • the onlyLocals option was moved and renamed to the modules.exportOnlyLocals option
  • function arguments of the import option were changed, it is now funciton(url, media, resourcePath) {}
  • inline syntax was changed, please write ~ before the file request, i.e. rewrite url(~!!loader!package/img.png) to url(!!loader!~package/img.png)
Features
Bug Fixes
  • resolution algorithm, you don't need ~ inside packages in node_modules (76f1480)

Renovate configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the 🤖 Type: Dependencies Dependency updates or something similar label Jul 27, 2020
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2020

🦋 Changeset is good to go

Latest commit: c84ae80

We got this.

This PR includes changesets to release 4 packages
Name Type
@commercetools-frontend/mc-scripts Patch
merchant-center-application-template-starter Patch
playground Patch
@commercetools-local/visual-testing-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/k0yqwgy2e
✅ Preview: https://merchant-center-application-kit-git-renovate-css-loader-4x.commercetools.vercel.app

@vercel vercel bot temporarily deployed to Preview July 27, 2020 01:40 Inactive
@vercel vercel bot temporarily deployed to Preview July 27, 2020 06:54 Inactive
@vercel vercel bot temporarily deployed to Preview July 27, 2020 06:55 Inactive
@tdeekens
Copy link
Contributor

@emmenko the changes here a bit hefty. I think only one affects us. I wonder though if it's considered breaking for consumers or not.

CleanShot 2020-07-27 at 08 51 56@2x

Any thoughts?

@emmenko
Copy link
Member

emmenko commented Jul 27, 2020

Hmm if the behavior from the consumer side does not change, we don't need to mark it as breaking I suppose.

@tdeekens
Copy link
Contributor

Hmm if the behavior from the consumer side does not change, we don't need to mark it as breaking I suppose.

Yeah, strictly speaking no, I agree. But e.g. Node version changes. Webpack version. The latter we encapsulate. The first not strictly.

Anyway, All good. I think patch is fine.

@tdeekens tdeekens added the 🚀 Status: ship it Triggers an merge if rules match via bot label Jul 27, 2020
@kodiakhq kodiakhq bot merged commit ba30472 into master Jul 27, 2020
@kodiakhq kodiakhq bot deleted the renovate/css-loader-4.x branch July 27, 2020 07:22
@ghost ghost mentioned this pull request Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Status: ship it Triggers an merge if rules match via bot 🤖 Type: Dependencies Dependency updates or something similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants