-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency css-loader to v4 #1655
Conversation
🦋 Changeset is good to goLatest commit: c84ae80 We got this. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/k0yqwgy2e |
@emmenko the changes here a bit hefty. I think only one affects us. I wonder though if it's considered breaking for consumers or not. Any thoughts? |
Hmm if the behavior from the consumer side does not change, we don't need to mark it as breaking I suppose. |
Yeah, strictly speaking no, I agree. But e.g. Node version changes. Webpack version. The latter we encapsulate. The first not strictly. Anyway, All good. I think patch is fine. |
This PR contains the following updates:
3.6.0
->4.0.0
Release Notes
webpack-contrib/css-loader
v4.0.0
Compare Source
⚠ BREAKING CHANGES
Node.js
version is10.13.0
webpack
version is4.27.0
esModule
option istrue
by defaultsourceMap
option depends on thedevtool
optionicss
plugin disable by default, you need to setup themodules
option to enable itmodules
option istrue
by default for all files matching/\.module\.\w+$/i.test(filename)
regular expression,module.auto
istrue
by defaultmodules.context
option was renamed to themodules.localIdentContext
optionmodules.localIdentContext
value iscompiler.context
for themodule.getLocalIdent
optionmodules.hashPrefix
option was renamed to themodules.localIdentHashPrefix
optionlocalsConvention
option was moved and renamed to themodules.exportLocalsConvention
optiongetLocalIndent
option should be alwaysFunction
and should always returnString
valueonlyLocals
option was moved and renamed to themodules.exportOnlyLocals
optionimport
option were changed, it is nowfunciton(url, media, resourcePath) {}
~
before the file request, i.e. rewriteurl(~!!loader!package/img.png)
tourl(!!loader!~package/img.png)
Features
@value
supports importingurl()
(#1126) (7f49a0a)url()
resolving algorithm (bc19ddd)style
field from package.json (#1099) (edf5347)file:
protocol (5604205)Bug Fixes
~
inside packages innode_modules
(76f1480)Renovate configuration
📅 Schedule: "before 3am on Monday" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.