chore: ugrade to react-intl v4

[emmenko]

I tried things locally and I didn't get any error this time. So maybe "it just works" now?

Eventually, we can also remove babel-plugin-macros. I don't know of any use case we have that require the macro plugin.

[changeset-bot]

🦋 Changeset is good to go

Latest commit: 93dd8f6

We got this.

This PR includes changesets to release 9 packages

Name	Type
merchant-center-application-template-starter	Minor
@commercetools-frontend/application-components	Minor
@commercetools-frontend/application-shell	Minor
@commercetools-frontend/mc-scripts	Minor
@commercetools-frontend/react-notifications	Minor
playground	Minor
@commercetools-local/visual-testing-app	Minor
@commercetools-website/custom-applications	Minor
@commercetools-website/components-playground	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/6fh5pnvol
✅ Preview: https://merchant-center-application-kit-git-nm-react-intl-v4.commercetools.now.sh

[tdeekens]

Eventually, we can also remove babel-plugin-macros. I don't know of any use case we have that require the macro plugin.

I can't recall us using it. Maybe we wanted to use it for GraphQL or the rule buider.

[tdeekens]

@emmenko can we actually say what's breaking on our end here towards consumers? It's late, maybe I don't see it :)

[emmenko]

The version bump of the peer dependency is what makes it breaking.

[tdeekens]

Just didn’t see the peer dep bump. Thought we could „claim“ we just work with v3 or v4.

[emmenko]

In theory yes, but we also don't know what features of v3 users are using. So only supporting v4 seems a safer bet.

I don't have a super strong opinion though.

[tdeekens]

Do we have a list of potential features breaking? We could also add it as a range of 3.x || 4.x for now if possible.

[tdeekens]

@emmenko any input regarding my previous comment ⏫.

[emmenko]

Here are the documented changes: https://formatjs.io/docs/react-intl/upgrade-guide-4x

Do you prefer to keep the range then?

[tdeekens]

Do you prefer to keep the range then?

What I thought was to allow users to use both 3.x and 4.x. What they use then depends on how their messages should look like and what's allowed. Instead of forcing them to migrate to the newer version which we don't have to require.

Does that make sense? Maybe I am reading/read the release notes wrong.

[adnasa]

Adding @ahmehri to the PR as he is refactoring routing.

[ahmehri]

@adnasa I couldn't find the relationship between this PR and the refactoring of routing, can you elaborate on that?

[adnasa]

I never checked the file changes so I just assumed they are related.
but I think the main reason I change assignee is because my attention is needed else where and you attempted to upgrade this yourself. so it's worth looking into?

but if you don't want to review, all good. I'll do it