Skip to content

chore: sync 1 org-standard workflow stub(s) from petry-projects/.github - #404

Closed
don-petry wants to merge 1 commit into
mainfrom
standards-sync/workflows-20260722
Closed

don-petry wants to merge 1 commit into
mainfrom
standards-sync/workflows-20260722

Conversation

@don-petry

@don-petry don-petry commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

User description

Syncs the following org-standard workflow stub(s) from petry-projects/.github (standards/workflows/), deployed verbatim:

  • dev-lead.yml

Opened by scripts/deploy-standard-workflows.sh. Stubs are thin callers; all behaviour lives in the reusables. See standards/ci-standards.md. Labeled standards-sync and left for the normal review/auto-merge pipeline — the deploy script never merges directly.


CodeAnt-AI Description

Update the Dev-Lead workflow stub to use the v1 ring channel

What Changed

  • The Dev-Lead workflow now points to the v1-ring1 channel instead of the old stable channel
  • The matching reference used by the workflow was updated so both values stay in sync
  • The SonarCloud note was simplified to reflect the single required inline marker; the workflow still copies cleanly into adopting repos

Impact

✅ Consistent Dev-Lead workflow rollout
✅ Safer channel-based updates
✅ Fewer SonarCloud copy-time failures

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@don-petry don-petry added the standards-sync Org-standard workflow stub synced from petry-projects/.github label Jul 22, 2026
@don-petry
don-petry requested a review from a team as a code owner July 22, 2026 11:44
@don-petry don-petry added the standards-sync Org-standard workflow stub synced from petry-projects/.github label Jul 22, 2026
@codeant-ai

codeant-ai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR d7efebf Jul 22, 2026 · 11:44 11:45

Updated in place by CodeAnt AI · last 5 reviews

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6a2ae75e-52dd-4337-9a57-ae84e48be0df

📥 Commits

Reviewing files that changed from the base of the PR and between ae380d5 and d7efebf.

📒 Files selected for processing (1)
  • .github/workflows/dev-lead.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch standards-sync/workflows-20260722

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Jul 22, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Sync dev-lead workflow stub to v1-ring1 reusable channel pin

⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Sync the org-standard dev-lead workflow stub verbatim.
• Re-pin the reusable workflow + agent ref to the dev-lead/v1-ring1 channel.
• Simplify SonarCloud guidance comments while retaining the S7637 inline suppression.
Diagram

graph TD
  A["Repo workflow stub: dev-lead.yml"] --> B{{"Reusable workflow: dev-lead-reusable.yml"}} --> C["Dev-lead automation"]
  A --> D["GitHub Actions runner"]
  A --> E["Repo secrets (inherit)"]
Loading
High-Level Assessment

Keeping the stub deployed verbatim is the right approach for standards-sync repos: it minimizes drift and keeps behavior centralized in the reusable workflow. While pinning to immutable SHAs would improve supply-chain immutability, it conflicts with the established ring/channel promotion model that this workflow explicitly documents and uses.

Files changed (1) +10 / -14

Other (1) +10 / -14
dev-lead.ymlRe-pin dev-lead reusable workflow to v1-ring1 and adjust Sonar notes +10/-14

Re-pin dev-lead reusable workflow to v1-ring1 and adjust Sonar notes

• Updates the reusable workflow reference and 'agent_ref' from the previous stable channel to 'dev-lead/v1-ring1'. Simplifies the SonarCloud NOSONAR documentation (keeps the S7637 suppression explanation) and removes the inline comment/NOSONAR marker on 'secrets: inherit'.

.github/workflows/dev-lead.yml

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 22, 2026 11:45
@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Quality Gate (static analysis)
Root cause: Lint/style

The diff for .github/workflows/dev-lead.yml removes the inline # NOSONAR(githubactions:S7635) suppression comment from the secrets: inherit line, while also rewriting the header comment block to only describe the remaining S7637 marker. Without that marker, SonarCloud rule githubactions:S7635 ("external reusable workflows should not inherit all secrets") now flags that line as a new issue, which fails the Quality Gate on this PR.

Suggested fix: Restore the # NOSONAR(githubactions:S7635) first-party trusted reusable suffix on the secrets: inherit line (and the corresponding explanation in the header comment block), consistent with ci-standards.md#sonarcloud-exemption-first-party-reusable-ref-s7637.

View run logs

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 📜 Skill insights (0)

Context used
✅ Compliance rules (platform): 150 rules
✅ Skills: 7 invoked
  bmad-qa-generate-e2e-tests
  bmad-testarch-trace
  bmad-testarch-ci
  bmad-testarch-atdd
  bmad-testarch-framework
  bmad-testarch-test-review
  bmad-testarch-automate

Grey Divider


Action required

1. S7635 suppression removed 🐞 Bug ☼ Reliability
Description
The PR removes the inline # NOSONAR(githubactions:S7635) suppression from secrets: inherit in
the dev-lead workflow stub, which can re-trigger SonarCloud rule githubactions:S7635 for this file.
This repo’s Sonar config does not ignore S7635 for dev-lead.yml, so the SonarCloud Quality Gate /
GitHub Advanced Security check may start failing on this change.
Code

.github/workflows/dev-lead.yml[67]

+    secrets: inherit
Relevance

⭐⭐⭐ High

They consistently restore S7635 inline suppression on secrets: inherit; accepted in PRs #395 and
#391.

PR-#395
PR-#391

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
dev-lead.yml now has secrets: inherit without the S7635 NOSONAR marker, while this repo’s Sonar
configuration only ignores S7635 for other stubs (not dev-lead). Other stubs still include the S7635
inline suppression, indicating it’s expected for this pattern.

.github/workflows/dev-lead.yml[59-68]
sonar-project.properties[16-17]
sonar-project.properties[50-62]
.github/workflows/dependabot-automerge.yml[33-39]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`secrets: inherit` in `.github/workflows/dev-lead.yml` no longer carries the inline `# NOSONAR(githubactions:S7635)` marker, even though other first-party reusable workflow stubs in this repo keep it to suppress SonarCloud’s S7635 rule.

Because `sonar-project.properties` does **not** configure an S7635 ignore for `dev-lead.yml`, SonarCloud can report a new S7635 issue for this file and potentially fail the Quality Gate / security check.

### Issue Context
- This repo suppresses S7635 for some workflow stubs via `sonar-project.properties`, but not for `dev-lead.yml`.
- Other stubs rely on the inline `# NOSONAR(githubactions:S7635)` comment on `secrets: inherit`.

### Fix
Re-add the inline suppression on the `secrets: inherit` line in `dev-lead.yml` (recommended, since this file is meant to be copied verbatim into adopting repos), e.g.:

```yml
secrets: inherit  # NOSONAR(githubactions:S7635) first-party trusted reusable
```

### Fix Focus Areas
- .github/workflows/dev-lead.yml[64-67]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Wrong channel in comment 🐞 Bug ⚙ Maintainability
Description
The dev-lead job comment says it’s pinned/promoted via dev-lead/v1-stable, but the actual uses:
ref and agent_ref are dev-lead/v1-ring1. This mismatch can mislead maintainers/adopters about
which channel is actually in effect and increase standards drift risk.
Code

.github/workflows/dev-lead.yml[R59-66]

+    # Pinned to the moving dev-lead/v1-stable channel tag, not @main, so a broken
    # change to dev-lead can no longer gate its own fix (the self-host circular
-    # dependency). Promotion is done by moving the dev-lead/stable tag centrally; this
+    # dependency). Promotion is done by moving the dev-lead/v1-stable tag centrally; this
    # caller is never edited on release. agent_ref threads the same channel into
    # dev-lead's own scripts/prompts checkout. See https://github.com/petry-projects/.github/blob/main/standards/ci-standards.md#dev-lead-agent.
-    uses: petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@dev-lead/stable  # NOSONAR(githubactions:S7637) first-party channel ref
+    uses: petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@dev-lead/v1-ring1  # NOSONAR(githubactions:S7637) first-party channel ref
    with:
-      agent_ref: dev-lead/stable
-    secrets: inherit  # NOSONAR(githubactions:S7635) first-party trusted reusable
+      agent_ref: dev-lead/v1-ring1
Relevance

⭐⭐⭐ High

Team fixes comment/config mismatches; comment-alignment accepted in PR #383; channel-drift addressed
in PR #391.

PR-#383
PR-#391

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The comment explicitly mentions dev-lead/v1-stable, while the actual workflow pin and the threaded
agent_ref are dev-lead/v1-ring1 in the same block.

.github/workflows/dev-lead.yml[59-66]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
In `.github/workflows/dev-lead.yml`, the dev-lead job comment describes the workflow as pinned to/promoted by moving `dev-lead/v1-stable`, but the actual pinned ref is `dev-lead/v1-ring1` (both in `uses:` and `agent_ref`).

### Issue Context
This file is intended to be copied verbatim across repos; comments in the stub are operational guidance. Incorrect channel names can cause confusion during incidents or future channel promotions.

### Fix
Update the comment text to reference `dev-lead/v1-ring1` (or, if `v1-stable` is truly intended, change both `uses:` and `agent_ref` back to `dev-lead/v1-stable` so they match).

### Fix Focus Areas
- .github/workflows/dev-lead.yml[59-66]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

agent_ref: dev-lead/stable
secrets: inherit # NOSONAR(githubactions:S7635) first-party trusted reusable
agent_ref: dev-lead/v1-ring1
secrets: inherit

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. S7635 suppression removed 🐞 Bug ☼ Reliability

The PR removes the inline # NOSONAR(githubactions:S7635) suppression from secrets: inherit in
the dev-lead workflow stub, which can re-trigger SonarCloud rule githubactions:S7635 for this file.
This repo’s Sonar config does not ignore S7635 for dev-lead.yml, so the SonarCloud Quality Gate /
GitHub Advanced Security check may start failing on this change.
Agent Prompt
### Issue description
`secrets: inherit` in `.github/workflows/dev-lead.yml` no longer carries the inline `# NOSONAR(githubactions:S7635)` marker, even though other first-party reusable workflow stubs in this repo keep it to suppress SonarCloud’s S7635 rule.

Because `sonar-project.properties` does **not** configure an S7635 ignore for `dev-lead.yml`, SonarCloud can report a new S7635 issue for this file and potentially fail the Quality Gate / security check.

### Issue Context
- This repo suppresses S7635 for some workflow stubs via `sonar-project.properties`, but not for `dev-lead.yml`.
- Other stubs rely on the inline `# NOSONAR(githubactions:S7635)` comment on `secrets: inherit`.

### Fix
Re-add the inline suppression on the `secrets: inherit` line in `dev-lead.yml` (recommended, since this file is meant to be copied verbatim into adopting repos), e.g.:

```yml
secrets: inherit  # NOSONAR(githubactions:S7635) first-party trusted reusable
```

### Fix Focus Areas
- .github/workflows/dev-lead.yml[64-67]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

jobs:
dev-lead:
# Pinned to the moving dev-lead/stable channel tag, not @main, so a broken
# Pinned to the moving dev-lead/v1-stable channel tag, not @main, so a broken

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

2. Wrong channel in comment 🐞 Bug ⚙ Maintainability

The dev-lead job comment says it’s pinned/promoted via dev-lead/v1-stable, but the actual uses:
ref and agent_ref are dev-lead/v1-ring1. This mismatch can mislead maintainers/adopters about
which channel is actually in effect and increase standards drift risk.
Agent Prompt
### Issue description
In `.github/workflows/dev-lead.yml`, the dev-lead job comment describes the workflow as pinned to/promoted by moving `dev-lead/v1-stable`, but the actual pinned ref is `dev-lead/v1-ring1` (both in `uses:` and `agent_ref`).

### Issue Context
This file is intended to be copied verbatim across repos; comments in the stub are operational guidance. Incorrect channel names can cause confusion during incidents or future channel promotions.

### Fix
Update the comment text to reference `dev-lead/v1-ring1` (or, if `v1-stable` is truly intended, change both `uses:` and `agent_ref` back to `dev-lead/v1-stable` so they match).

### Fix Focus Areas
- .github/workflows/dev-lead.yml[59-66]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@don-petry

Copy link
Copy Markdown
Contributor Author

Superseding: this PR was generated from the pre-#876 dev-lead template that lacked the # NOSONAR(githubactions:S7635) marker on secrets: inherit. #876 restored the marker in the template; after the driver is made marker-aware (tracked in the new follow-up), a re-sweep will re-open this with correct pins AND the S7635 marker (maximum quality). Closing to avoid deploying a marker-less stub.

@don-petry don-petry closed this Jul 22, 2026
auto-merge was automatically disabled July 22, 2026 16:43

Pull request was closed

@don-petry
don-petry deleted the standards-sync/workflows-20260722 branch July 22, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files standards-sync Org-standard workflow stub synced from petry-projects/.github

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant