Skip to content

feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref - #395

Merged
don-petry merged 2 commits into
mainfrom
dev-lead/issue-370-20260721-1922
Jul 21, 2026
Merged

don-petry merged 2 commits into
mainfrom
dev-lead/issue-370-20260721-1922

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Closes #370

Implemented by dev-lead agent. Please review.

Copilot AI review requested due to automatic review settings July 21, 2026 19:24
@don-petry
don-petry requested a review from a team as a code owner July 21, 2026 19:24
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4a49f375-bb13-4702-ba59-d168107d341b

📥 Commits

Reviewing files that changed from the base of the PR and between 98042e4 and 44e798e.

📒 Files selected for processing (1)
  • .github/workflows/dev-lead.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-370-20260721-1922

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread .github/workflows/dev-lead.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns TalkTerm’s dev-lead.yml thin caller stub with the org compliance standard so the Dev-Lead reusable workflow is invoked consistently (and passes the required agent_ref channel input).

Changes:

  • Normalized the secrets: inherit stanza formatting to match the canonical standards/workflows/dev-lead.yml template.
  • Removes the extra inline suppression comment on secrets: inherit (the standard template does not include it).

@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Quality Gate (static analysis)
Root cause: Lint/style

The diff for this PR removes the # NOSONAR(githubactions:S7635) suppression comment that previously followed secrets: inherit in .github/workflows/dev-lead.yml. Rule S7635 flags reusable-workflow calls that pass all secrets through; with the suppression gone, SonarCloud now surfaces this as a new/unresolved security hotspot, which fails the quality gate.

Suggested fix: Restore the # NOSONAR(githubactions:S7635) first-party trusted reusable comment on the secrets: inherit line in .github/workflows/dev-lead.yml (or explicitly mark the hotspot as reviewed/safe in the SonarCloud dashboard if the suppression is no longer wanted).

View run logs

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) July 21, 2026 19:37
@don-petry
don-petry disabled auto-merge July 21, 2026 19:46
@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 21, 2026 19:48

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 44e798eeac2642419928b374175b74e72ab145d8
Review mode: triage-approved (single reviewer)

Summary

Comments-only change to the dev-lead.yml thin caller stub. The compliance finding (#370) required with: agent_ref: dev-lead/<channel>, which was already present on main — the finding was stale. The dev-lead re-synced the stub from the canonical template (commit 20f9511), which dropped the repo's # NOSONAR(githubactions:S7635) marker on secrets: inherit and broke the SonarCloud quality gate; the follow-up commit (44e798e) restored the marker and updated the header comment to document both NOSONAR markers. Net diff vs main: header comment block only. No changes to triggers, permissions, secrets behavior, or the uses: pin.

Linked issue analysis

Issue #370 (compliance-audit: dev-lead-stub-agent-ref) requires the caller stub to pass agent_ref: dev-lead/<channel>. Verified at head SHA: agent_ref: dev-lead/stable is present and matches the uses: channel pin. The requirement was in fact already satisfied on main, so this PR's re-sync is a no-op functionally, but the head file fully complies with the standard and the issue is legitimately closable.

Findings

  • No security or correctness issues. The delta is documentation comments only.
  • The file intentionally deviates from the canonical standards/workflows/dev-lead.yml template by carrying the # NOSONAR(githubactions:S7635) marker on secrets: inherit (needed for this repo's SonarCloud gate; pre-existing on main and consistent with other stubs like dependabot-automerge.yml). Non-blocking suggestion: upstream this marker + header documentation into the canonical template so future verbatim re-syncs don't re-break the quality gate.
  • Review threads: 1 thread from github-advanced-security (S7635 hotspot on the intermediate commit) — resolved and outdated; SonarCloud now reports 0 security hotspots.
  • Secret scan MCP tool not available in this environment; gitleaks CI check passed (noted, non-blocking).

CI status

All required checks green at head 44e798e: SonarCloud Quality Gate PASSED (0 new issues, 0 hotspots), CodeQL (actions, python) SUCCESS, Secret scan (gitleaks) SUCCESS, AgentShield SUCCESS, PR Review Agent SUCCESS, CodeRabbit SUCCESS. Skipped jobs are conditional (dependabot-automerge, per-ecosystem dependency audits, ci-relay).


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit 3d6abee into main Jul 21, 2026
20 checks passed
@don-petry
don-petry deleted the dev-lead/issue-370-20260721-1922 branch July 21, 2026 21:23
don-petry added a commit that referenced this pull request Aug 20, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 31, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 31, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 31, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Sep 1, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Sep 4, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Sep 4, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Sep 7, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Sep 7, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Sep 7, 2026
* feat: implement issue #370 — Compliance: dev-lead-stub-agent-ref

* chore: dev-lead update (review-changes) [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: dev-lead-stub-agent-ref

4 participants