Skip to content

feat: implement issue #1286 — persona-mention router skips any PR whose body quotes '<!-- persona:' — narrow the PR-path marker check to a body authored with the marker - #1287

Merged
don-petry merged 6 commits into
mainfrom
dev-lead/issue-1286-20261010-2113
Oct 11, 2026

fix(reviews): assert job-level if conditions in persona-mention workf…

3dfef1e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Oct 11, 2026 in 27s

Annotations

Check warning on line 96 in scripts/lib/persona-mention.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=petry-projects_.github&issues=AaEnt95b5rlBucsWitak&open=AaEnt95b5rlBucsWitak&pullRequest=1287

Check failure on line 91 in scripts/lib/persona-mention.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.

See more on https://sonarcloud.io/project/issues?id=petry-projects_.github&issues=AaEnt95b5rlBucsWitaj&open=AaEnt95b5rlBucsWitaj&pullRequest=1287

Check failure on line 89 in scripts/lib/persona-mention.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.

See more on https://sonarcloud.io/project/issues?id=petry-projects_.github&issues=AaEnt95b5rlBucsWitai&open=AaEnt95b5rlBucsWitai&pullRequest=1287