Skip to content

Cross compile ujson.circe to Scala JS #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 10, 2025
Merged

Cross compile ujson.circe to Scala JS #681

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ca001b
Cross compile ujson.circe to Scala JS
majk-p Sep 10, 2025
a679bba
extract common part of circe module
majk-p Sep 10, 2025
ee7453c
fix module deps
majk-p Sep 10, 2025
f1ed9d1
make CommonCirceModule extend CommonPublishModule
majk-p Sep 10, 2025
fbe6f99
fix stackoverflow
majk-p Sep 10, 2025
a10e241
Use platformed dependency
lolgab Sep 10, 2025
8c00af8
Fix and test ujson-circe on all platforms
lolgab Sep 10, 2025
9704d09
Add ujson.circe.jvm() dependency also on Scala 3
lolgab Sep 10, 2025
c31357d
Add ujson.circe.native() dependency to upickle native test
lolgab Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,13 @@ object ujson extends Module{
def mvnDeps = Seq(mvn"io.circe::circe-parser:$circeVersion")
}

object js extends Cross[CirceJsModule](scalaVersions)
trait CirceJsModule extends CommonJsModule{
def moduleDeps = Seq(ujson.js())
val circeVersion = "0.14.14"
def mvnDeps = Seq(mvn"io.circe::circe-parser:$circeVersion")
Copy link
Member

@lolgab lolgab Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract these in a trait as we do in CommonCoreModule and then extend it in jvm, js and native?

Copy link
Contributor Author

@majk-p majk-p Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, done

}

object native extends Cross[CirceNativeModule](scalaVersions)
trait CirceNativeModule extends CommonNativeModule{
def moduleDeps = Seq(ujson.native())
Expand Down