Cross compile ujson.circe to Scala JS #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majk-p
force-pushed
the
ujson-circe-js
branch
from
db1f873 to
7ca001b
Compare
lolgab
requested changes
Sep 10, 2025
build.mill
Outdated
Comment on lines
233
to
234
| val circeVersion = "0.14.14" | ||
| def mvnDeps = Seq(mvn"io.circe::circe-parser:$circeVersion") |
There was a problem hiding this comment.
Can you extract these in a trait as we do in CommonCoreModule and then extend it in jvm, js and native?
lolgab
approved these changes
Sep 10, 2025
lolgab
reviewed
Sep 10, 2025
build.mill
Outdated
| override def moduleDeps = this.moduleDeps ++ Seq(ujson.native()) | ||
| } | ||
|
|
||
| trait CommonCirceModule { |
There was a problem hiding this comment.
This should extend CommonPublishModule
|
I noticed that we were not using the correct platformed dependency and we didn't notice because the test was running only on the jvm target. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.