fix: correctly handle cancellation of navigations

[richardjelinek-fastest]

Tries to fix #118

Passes initial URL parameters to onNavigate so we can catch them in beforeLoad at page load.
Hopefully cancel all navigations if they're not the most recent one. Old logic did not work from my tests.

Return Error in navigate so linters (ESLint) don't complain about throwing void.

[changeset-bot]

🦋 Changeset detected

Latest commit: 59f8c22

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
sv-router	Ignored	Preview		Sep 16, 2025 4:49pm

[colinlienard]

Hopefully cancel all navigations if they're not the most recent one. Old logic did not work from my tests.

@richardjelinek-fastest Curious to see your method of test, I didn’t see issues when testing this, but maybe I missed something

[richardjelinek-fastest]

Hopefully cancel all navigations if they're not the most recent one. Old logic did not work from my tests.

@richardjelinek-fastest Curious to see your method of test, I didn’t see issues when testing this, but maybe I missed something

I've created a min-repro demo: https://github.com/richardjelinek-fastest/sv-router-navigation-bug

[colinlienard]

I don't see the issue in your repro 🤔

[richardjelinek-fastest]

I don't see the issue in your repro 🤔

Ok I now see why.
It only happens after a hot-reload.

I also added a new condition that redirects from the homepage, so you don't have to go into the /nested page to check the possible bug.

[richardjelinek-fastest]

@colinlienard Do you plan to look into it? 👀 Just bumping, it's okay if you're busy :)

[colinlienard]

I was still not able to reproduce the issue...

[richardjelinek-fastest]

@colinlienard Ok it's not that easily reproducible. Here's a video of the weird bug happening.
It seems to work when opening the site a certain way.

I've also updated the repro demo once again...

Working on an update to this PR. It's missing the change that seems to fix it.

Screencast_20250819_212333.webm

[richardjelinek-fastest]

Don't know why the test is failing in the actions. Locally it passes :'(

[vercel]

@richardjelinek-fastest is attempting to deploy a commit to the Colin Lienard's projects Team on Vercel.

A member of the Team first needs to authorize it.