[pull] main from lynx-family:main#593
Merged
pull[bot] merged 1 commit intocolinaaa:mainfrom Apr 22, 2026
Merged
Conversation
@coderabbitai summary ## Overview - Snapshot runtime internals were still spread across public-looking runtime source and test roots, which made it unclear which code belongs to the legacy Snapshot backend and which paths ET should be allowed to depend on. - This change contains those Snapshot-owned runtime modules and tests under snapshot-specific roots while keeping the existing package entries and runtime root modules as the stable integration surface. ## Key Points - Moves the legacy Snapshot implementation directories under `packages/react/runtime/src/snapshot/` instead of introducing a broad facade layer. - Moves Snapshot-specific runtime tests, including CSS and shared test utilities, under `packages/react/runtime/__test__/snapshot/` and keeps non-Snapshot runtime tests outside that subtree. - Adds a guardrail suite that fails if old Snapshot implementation roots reappear, if ET code imports Snapshot-private paths, or if package metadata exposes stale internal locations. - Leaves the existing dark-mode transform self-import unchanged because `__SetClassesDarkMode` is not exported from the runtime root today; the guardrail documents that as a narrow known exception. ## Checklist - [x] Tests updated (or not required). - [x] Documentation updated (or not required). - [x] Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )