Skip to content

fix(workflows): make archon-adversarial-dev sed replacement macOS-safe based on #1155 #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LaplaceYoung wants to merge 2 commits into from
Closed

fix(workflows): make archon-adversarial-dev sed replacement macOS-safe based on #1155 #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b201b
fix(workflows): harden adversarial-dev sed portability checks
LaplaceYoung Apr 22, 2026
8e4b866
Merge pull request #1 from LaplaceYoung/young/fix-issues-in-pr-and-co…
LaplaceYoung Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .archon/workflows/defaults/archon-adversarial-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ nodes:
"status": "running"
}
STATEEOF
sed -i "s/SPRINT_COUNT_PLACEHOLDER/$SPRINT_COUNT/" "$ARTIFACTS/state.json"
STATE_TMP="$ARTIFACTS/state.json.tmp"
sed "s/SPRINT_COUNT_PLACEHOLDER/$SPRINT_COUNT/" "$ARTIFACTS/state.json" > "$STATE_TMP"
mv "$STATE_TMP" "$ARTIFACTS/state.json"
Comment thread
LaplaceYoung marked this conversation as resolved.

echo "{\"totalSprints\": $SPRINT_COUNT, \"appDir\": \"$ARTIFACTS/app\", \"artifactsDir\": \"$ARTIFACTS\"}"
timeout: 30000
Expand Down
10 changes: 10 additions & 0 deletions packages/workflows/src/defaults/bundled-defaults.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,16 @@ describe('bundled-defaults', () => {
expect(content).toContain('workflow_name');
});

it('archon-adversarial-dev init-workspace should avoid non-portable sed -i', () => {
const content = BUNDLED_WORKFLOWS['archon-adversarial-dev'];
expect(content).toContain('STATE_TMP="$ARTIFACTS/state.json.tmp"');
expect(content).toContain(
'sed "s/SPRINT_COUNT_PLACEHOLDER/$SPRINT_COUNT/" "$ARTIFACTS/state.json" > "$STATE_TMP"'
);
expect(content).toContain('mv "$STATE_TMP" "$ARTIFACTS/state.json"');
expect(content).not.toMatch(/\bsed\s+-i(?:\s*(?:''|\"\"|\S+))?\b/);
});

it('should have valid YAML structure', () => {
// Workflows are YAML files, should parse without error
for (const [name, content] of Object.entries(BUNDLED_WORKFLOWS)) {
Expand Down