Merged
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
force-pushed
the
py-coverage
branch
from
29abb18 to
3f41dcd
Compare
Member
Also outputting the coverage info to the terminal by default (assuming it goes to stdout and it isn't too verbose) sounds good to me. A pull request for that would be appreciated. |
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
dirk-thomas
reviewed
Mar 26, 2020
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Member
|
Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of passing
--pytest-with-coverage, this also adds a print of the report to the terminal instead of only generatingxmlandhtmlreport.@dirk-thomas would you be ok with adding the report to terminal by default ? If so I'm happy to remove it from here and add it at https://github.com/colcon/colcon-core/blob/af7fa089962a9e9a35926734e17b00cfb4c780a6/colcon_core/task/python/test/pytest.py#L94