Add CloudWatch Metrics Build Status GH Action #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anas Abou Allaban <[email protected]>
|
Is the intention to check this in here? It points to an aws-robotics repository for e.g. the issues link |
thomas-moulard
requested changes
Feb 11, 2020
added 2 commits
February 11, 2020 09:22
Signed-off-by: Anas Abou Allaban <[email protected]>
Signed-off-by: Anas Abou Allaban <[email protected]>
The end goal is to put this in |
I have added the tests, however, there is a workaround added to the The code was validated in #132. |
added 5 commits
February 11, 2020 09:52
Signed-off-by: Anas Abou Allaban <[email protected]>
Signed-off-by: Anas Abou Allaban <[email protected]>
Signed-off-by: Anas Abou Allaban <[email protected]>
Signed-off-by: Anas Abou Allaban <[email protected]>
Signed-off-by: Anas Abou Allaban <[email protected]>
emersonknapp
approved these changes
Feb 12, 2020
added 2 commits
February 11, 2020 16:13
Signed-off-by: Anas Abou Allaban <[email protected]>
Signed-off-by: Anas Abou Allaban <[email protected]>
thomas-moulard
approved these changes
Feb 12, 2020
Signed-off-by: Anas Abou Allaban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a GH action that uses CW Metrics to log build successes or failures.
This includes the compiled JS and necessary node/linting/typescript config files.
An example of this running on the tox unit tests is in #132.
Signed-off-by: Anas Abou Allaban [email protected]