Use import {Octokit}

[nwtgck]

Hi,

The purpose of this PR is to remove the following error.

node_modules/@actions/github/lib/github.d.ts:2:8 - error TS2613: Module '"/.../node_modules/@octokit/rest/index"' has no default export. Did you mean to use 'import { Octokit } from "/.../node_modules/@octokit/rest/index"' instead?

2 import Octokit from '@octokit/rest';
         ~~~~~~~

[xt0rted]

This change was made i n v16.43.1 but the version in package.json is v16.15.0 which is why all the builds failed.

[nwtgck]

@xt0rted Thanks! Umm... Interesting...

Actually, my project using @actions/github fails in build-time when import Octokit from '@octokit/rest'; is used. To avoid this, I manually modify .d.ts in node_modules: nwtgck/actions-netlify#2.

[nwtgck]

I found the reason.

16.43.1 (2020-02-03)
Bug Fixes
TypeScript: named { Octokit } export (486eadd)

https://github.com/octokit/rest.js/releases/tag/v16.43.1

[technote-space]

^16.15.0 = 16.x
so v16.43.1 is installed.
I think this PR needs to be merged as soon as possible.

If you want to build with tsc now, add skipLibCheck setting.

tsconfig.json

{
  "compilerOptions": {
    "skipLibCheck": true,

   ...

  }
}

[nwtgck]

@technote-space Thank you very much for your useful tip: skipLibCheck. I didn't know that.

[hardboiled]

This will definitely fix the problem I mentioned in my comment. Thanks for opening!

[piraka9011]

Bump! Can we get this in soon please!

[joshmgross]

This resolves #333

[thboop]

Looks good to me!